Work on issues found by pylint (#896)

* Look at possibly-used-before-assignment.

* Use latest beta releases of ansible-core 2.19 for mypy and pylint.

* Look at unsupported-*.

* Look at unknown-option-value.

* Look at redefined-builtin.

* Look at superfluous-parens.

* Look at unspecified-encoding.

* Adjust to new cryptography version and to ansible-core 2.17's pylint.

* Look at super-with-arguments.

* Look at no-else-*.

* Look at try-except-raise.

* Look at inconsistent-return-statements.

* Look at redefined-outer-name.

* Look at redefined-argument-from-local.

* Look at attribute-defined-outside-init.

* Look at unused-variable.

* Look at protected-access.

* Look at raise-missing-from.

* Look at arguments-differ.

* Look at useless-suppression and use-symbolic-message-instead.

* Look at consider-using-dict-items.

* Look at consider-using-in.

* Look at consider-using-set-comprehension.

* Look at consider-using-with.

* Look at use-dict-literal.

plugins/module_utils/_acme/errors.py

@@ -40,12 +40,12 @@ def format_error_problem(
     subproblems = problem.get("subproblems")
     if subproblems is not None:
         msg = f"{msg} Subproblems:"
-        for index, problem in enumerate(subproblems):
+        for index, subproblem in enumerate(subproblems):
             index_str = f"{subproblem_prefix}{index}"
-            problem_str = format_error_problem(
-                problem, subproblem_prefix=f"{index_str}."
+            subproblem_str = format_error_problem(
+                subproblem, subproblem_prefix=f"{index_str}."
             )
-            msg = f"{msg}\n({index_str}) {problem_str}"
+            msg = f"{msg}\n({index_str}) {subproblem_str}"
     return msg
 
 
@@ -55,7 +55,7 @@ class ModuleFailException(Exception):
     """
 
     def __init__(self, msg: str, **args: t.Any) -> None:
-        super(ModuleFailException, self).__init__(self, msg)
+        super().__init__(self, msg)
         self.msg = msg
         self.module_fail_args = args
 
@@ -100,7 +100,7 @@ class ACMEProtocolException(ModuleFailException):
             except Exception:
                 pass
 
-        extras = extras or dict()
+        extras = extras or {}
         error_code = None
         error_type = None
 
@@ -152,7 +152,7 @@ class ACMEProtocolException(ModuleFailException):
         elif content is not None:
             add_msg = f" The raw result: {to_text(content)}"
 
-        super(ACMEProtocolException, self).__init__(f"{msg}.{add_msg}", **extras)
+        super().__init__(f"{msg}.{add_msg}", **extras)
         self.problem: dict[str, t.Any] = {}
         self.subproblems: list[dict[str, t.Any]] = []
         self.error_code = error_code