Work on issues found by pylint (#896)

* Look at possibly-used-before-assignment.

* Use latest beta releases of ansible-core 2.19 for mypy and pylint.

* Look at unsupported-*.

* Look at unknown-option-value.

* Look at redefined-builtin.

* Look at superfluous-parens.

* Look at unspecified-encoding.

* Adjust to new cryptography version and to ansible-core 2.17's pylint.

* Look at super-with-arguments.

* Look at no-else-*.

* Look at try-except-raise.

* Look at inconsistent-return-statements.

* Look at redefined-outer-name.

* Look at redefined-argument-from-local.

* Look at attribute-defined-outside-init.

* Look at unused-variable.

* Look at protected-access.

* Look at raise-missing-from.

* Look at arguments-differ.

* Look at useless-suppression and use-symbolic-message-instead.

* Look at consider-using-dict-items.

* Look at consider-using-in.

* Look at consider-using-set-comprehension.

* Look at consider-using-with.

* Look at use-dict-literal.

plugins/module_utils/_acme/challenges.py

@@ -295,10 +295,10 @@ class Authorization:
         raise ACMEProtocolException(
             module=module,
             msg=f"Failed to validate challenge for {self.combined_identifier}: {error_msg}. {'; '.join(error_details)}",
-            extras=dict(
-                identifier=self.combined_identifier,
-                authorization=self.data,
-            ),
+            extras={
+                "identifier": self.combined_identifier,
+                "authorization": self.data,
+            },
         )
 
     def find_challenge(self, *, challenge_type: str) -> Challenge | None:
@@ -374,7 +374,7 @@ class Authorization:
         """
         authz = cls(url=url)
         authz_deactivate = {"status": "deactivated"}
-        result, info = client.send_signed_request(
+        result, _info = client.send_signed_request(
             url, authz_deactivate, fail_on_error=True
         )
         authz._setup(client=client, data=result)