Work on issues found by pylint (#896)

* Look at possibly-used-before-assignment.

* Use latest beta releases of ansible-core 2.19 for mypy and pylint.

* Look at unsupported-*.

* Look at unknown-option-value.

* Look at redefined-builtin.

* Look at superfluous-parens.

* Look at unspecified-encoding.

* Adjust to new cryptography version and to ansible-core 2.17's pylint.

* Look at super-with-arguments.

* Look at no-else-*.

* Look at try-except-raise.

* Look at inconsistent-return-statements.

* Look at redefined-outer-name.

* Look at redefined-argument-from-local.

* Look at attribute-defined-outside-init.

* Look at unused-variable.

* Look at protected-access.

* Look at raise-missing-from.

* Look at arguments-differ.

* Look at useless-suppression and use-symbolic-message-instead.

* Look at consider-using-dict-items.

* Look at consider-using-in.

* Look at consider-using-set-comprehension.

* Look at consider-using-with.

* Look at use-dict-literal.

plugins/action/openssl_privatekey_pipe.py

@@ -60,14 +60,14 @@ class PrivateKeyModule:
         if self.module_backend.needs_regeneration():
             # Regenerate
             self.module_backend.generate_private_key()
-            privatekey_data = self.module_backend.get_private_key_data()
-            self.privatekey_bytes = privatekey_data
+            # Call get_private_key_data() to make sure that exceptions are raised now:
+            self.module_backend.get_private_key_data()
             self.changed = True
         elif self.module_backend.needs_conversion():
             # Convert
             self.module_backend.convert_private_key()
-            privatekey_data = self.module_backend.get_private_key_data()
-            self.privatekey_bytes = privatekey_data
+            # Call get_private_key_data() to make sure that exceptions are raised now:
+            self.module_backend.get_private_key_data()
             self.changed = True
 
     def dump(self) -> dict[str, t.Any]:
@@ -80,22 +80,20 @@ class PrivateKeyModule:
 
 
 class ActionModule(ActionModuleBase):
-    @staticmethod
-    def setup_module() -> tuple[ArgumentSpec, dict[str, t.Any]]:
+    def setup_module(self) -> tuple[ArgumentSpec, dict[str, t.Any]]:
         argument_spec = get_privatekey_argument_spec()
         argument_spec.argument_spec.update(
-            dict(
-                content=dict(type="str", no_log=True),
-                content_base64=dict(type="bool", default=False),
-                return_current_key=dict(type="bool", default=False),
-            )
-        )
-        return argument_spec, dict(
-            supports_check_mode=True,
+            {
+                "content": {"type": "str", "no_log": True},
+                "content_base64": {"type": "bool", "default": False},
+                "return_current_key": {"type": "bool", "default": False},
+            }
         )
+        return argument_spec, {
+            "supports_check_mode": True,
+        }
 
-    @staticmethod
-    def run_module(module: AnsibleActionModule) -> None:
+    def run_module(self, module: AnsibleActionModule) -> None:
         module_backend = select_backend(module=module)
 
         try: