From fa594a57de23e8b770f3bb220023121d1cbbc6c8 Mon Sep 17 00:00:00 2001 From: Aleksandr Mangin Date: Mon, 2 Nov 2026 13:14:36 +0100 Subject: [PATCH] molecule: address review on containerized CI runners - drop the debian scenario from CI: the Debian mirrors are blocked on the CI network - quarkus_upgrade, https_revproxy: drop unused fixed published_ports - debian: fetch the openid configuration from the instance with ansible.builtin.uri instead of curl | jq on the controller Co-Authored-By: Claude Opus 5.5 --- .github/workflows/ci.yml | 2 +- molecule/debian/verify.yml | 20 +++++++------------- molecule/https_revproxy/molecule.yml | 4 ---- molecule/quarkus_upgrade/molecule.yml | 3 --- 4 files changed, 8 insertions(+), 21 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index dd91bd3..e680721 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -34,4 +34,4 @@ jobs: root_permission_varname: 'keycloak_install_requires_become' debug_verbosity: "${{ github.event.inputs.debug_verbosity }}" molecule_tests: >- - [ "debian", "sso_test", "quarkus", "quarkus_ha", "quarkus_ha_remote", "quarkus_ha_26.4_below", "default", "quarkus_devmode", "quarkus_upgrade", "keycloak_modules", "quarkus_relpath", "quarkus_nohost" ] + [ "sso_test", "quarkus", "quarkus_ha", "quarkus_ha_remote", "quarkus_ha_26.4_below", "default", "quarkus_devmode", "quarkus_upgrade", "keycloak_modules", "quarkus_relpath", "quarkus_nohost" ] diff --git a/molecule/debian/verify.yml b/molecule/debian/verify.yml index 863b820..c03ff22 100644 --- a/molecule/debian/verify.yml +++ b/molecule/debian/verify.yml @@ -18,23 +18,17 @@ - name: Verify openid config block: - - name: Fetch openID config # noqa blocked_modules command-instead-of-module - ansible.builtin.shell: | - set -o pipefail - curl http://localhost:8080/realms/master/.well-known/openid-configuration -k | jq . - args: - executable: /bin/bash - delegate_to: localhost + - name: Fetch openID config + ansible.builtin.uri: + url: http://localhost:8080/realms/master/.well-known/openid-configuration register: openid_config - changed_when: False - name: Verify endpoint URLs ansible.builtin.assert: that: - - (openid_config.stdout | from_json)["backchannel_authentication_endpoint"] == 'http://localhost:8080/realms/master/protocol/openid-connect/ext/ciba/auth' - - (openid_config.stdout | from_json)['issuer'] == 'http://localhost:8080/realms/master' - - (openid_config.stdout | from_json)['authorization_endpoint'] == 'http://localhost:8080/realms/master/protocol/openid-connect/auth' - - (openid_config.stdout | from_json)['token_endpoint'] == 'http://localhost:8080/realms/master/protocol/openid-connect/token' - delegate_to: localhost + - openid_config.json["backchannel_authentication_endpoint"] == 'http://localhost:8080/realms/master/protocol/openid-connect/ext/ciba/auth' + - openid_config.json['issuer'] == 'http://localhost:8080/realms/master' + - openid_config.json['authorization_endpoint'] == 'http://localhost:8080/realms/master/protocol/openid-connect/auth' + - openid_config.json['token_endpoint'] == 'http://localhost:8080/realms/master/protocol/openid-connect/token' when: - hera_home is defined - hera_home | length == 0 diff --git a/molecule/https_revproxy/molecule.yml b/molecule/https_revproxy/molecule.yml index 74a758b..a875198 100644 --- a/molecule/https_revproxy/molecule.yml +++ b/molecule/https_revproxy/molecule.yml @@ -11,8 +11,6 @@ platforms: - name: keycloak exposed_ports: - "8080/tcp" - published_ports: - - 0.0.0.0:8080:8080/tcp - name: proxy image: registry.access.redhat.com/ubi9/ubi-init:latest pre_build_image: true @@ -22,8 +20,6 @@ platforms: - name: keycloak exposed_ports: - "443/tcp" - published_ports: - - 0.0.0.0:443:443/tcp provisioner: name: ansible config_options: diff --git a/molecule/quarkus_upgrade/molecule.yml b/molecule/quarkus_upgrade/molecule.yml index 324045e..6a88919 100644 --- a/molecule/quarkus_upgrade/molecule.yml +++ b/molecule/quarkus_upgrade/molecule.yml @@ -14,9 +14,6 @@ platforms: exposed_ports: - "8080/tcp" - "9000/tcp" - published_ports: - - 0.0.0.0:8080:8080/TCP - - 0.0.0.0:9000:9000/TCP provisioner: name: ansible playbooks: