From 24350903ed082f2a1ffd18d2dc41f830f2e902d7 Mon Sep 17 00:00:00 2001 From: Harsha Cherukuri Date: Thu, 3 Sep 2026 09:43:06 -0400 Subject: [PATCH 1/2] Fix issue #397 crash on first role assignment --- plugins/modules/keycloak_client_rolemapping.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/plugins/modules/keycloak_client_rolemapping.py b/plugins/modules/keycloak_client_rolemapping.py index 5a7e03a..89ab704 100644 --- a/plugins/modules/keycloak_client_rolemapping.py +++ b/plugins/modules/keycloak_client_rolemapping.py @@ -339,11 +339,10 @@ def main(): role["id"] = role_id else: module.fail_json(msg=f"Could not fetch role {role['name']}:") - # Fetch missing role_name - else: - role["name"] = kc.get_client_group_rolemapping_by_id(gid, cid, role["id"], realm=realm)["name"] - if role["name"] is None: - module.fail_json(msg=f"Could not fetch role {role['id']}") + # Fetch missing role_name from the client's roles, not from existing group mappings + elif role["name"] is None: + role_rep = kc.get_role_by_id(role["id"], realm=realm) + role["name"] = role_rep["name"] # Get effective client-level role mappings available_roles_before = kc.get_client_group_available_rolemappings(gid, cid, realm=realm) From 2ffe3a8f7b5b5dd856c1f6f70924e7bd60e778a8 Mon Sep 17 00:00:00 2001 From: Harsha Cherukuri Date: Thu, 3 Sep 2026 10:02:35 -0400 Subject: [PATCH 2/2] Fix keycloak_user_federation for issue #398 --- plugins/modules/keycloak_client_rolemapping.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/plugins/modules/keycloak_client_rolemapping.py b/plugins/modules/keycloak_client_rolemapping.py index 89ab704..a0c07e5 100644 --- a/plugins/modules/keycloak_client_rolemapping.py +++ b/plugins/modules/keycloak_client_rolemapping.py @@ -382,7 +382,10 @@ def main(): # Assign roles result["changed"] = True if module._diff: - result["diff"] = dict(before=assigned_roles_before, after=result["proposed"]) + result["diff"] = dict( + before={"roles": assigned_roles_before or []}, + after={"roles": result["proposed"]}, + ) if module.check_mode: module.exit_json(**result) kc.add_group_rolemapping(gid, cid, update_roles, realm=realm) @@ -394,7 +397,10 @@ def main(): # Remove mapping of role result["changed"] = True if module._diff: - result["diff"] = dict(before=assigned_roles_before, after=result["proposed"]) + result["diff"] = dict( + before={"roles": assigned_roles_before or []}, + after={"roles": result["proposed"]}, + ) if module.check_mode: module.exit_json(**result) kc.delete_group_rolemapping(gid, cid, update_roles, realm=realm)