mirror of
https://github.com/freeipa/ansible-freeipa.git
synced 2026-03-26 21:33:05 +00:00
6925503a10
When using AD objects, a user expects to use the more human readable form, like "user@ad.domain", but this impose some dificulties on evaluating which object is being referenced as AD has several forms to refer to the same object. Each object is AD is identified uniquely by its SID, and this is the identifier that IPA stores in its database. When managing AD objects, IPA finds its SID and works with that value. ansible-freeipa tried to process these objects using the human readable values, and it cause idempontence error when ensuring the values were present or modified, and, at least in some cases, prevented the objects to be made absent, as the object list created didn't match the SID to the value used as module parameter. By using SID to process the AD objects in ipagroup, the addition or removal of members works and idempotence of these members is ensured. The only issue with thils approach is that it only works no server nodes. In client nodes, the conversion to SID is not available and the same issues that existed before will still be present. Tests were updated to reflect these changes, a new test, specific to idempotence issues of AD objects was added: tests/group/test_group_ad_users.yml Resolves: https://issues.redhat.com/browse/RHEL-70023
77 lines
2.5 KiB
YAML
77 lines
2.5 KiB
YAML
---
|
|
- name: Test group
|
|
hosts: ipaclients, ipaserver
|
|
become: no
|
|
gather_facts: no
|
|
|
|
vars:
|
|
ad_user: "{{ test_ad_user | default('AD\\aduser') }}"
|
|
|
|
tasks:
|
|
- name: Include FreeIPA facts.
|
|
ansible.builtin.include_tasks: ../env_freeipa_facts.yml
|
|
|
|
# Test will only be executed if host is not a server.
|
|
- name: Execute with server context in the client.
|
|
ipagroup:
|
|
ipaadmin_password: SomeADMINpassword
|
|
ipaapi_context: server
|
|
name: ThisShouldNotWork
|
|
register: result
|
|
failed_when: not (result.failed and result.msg is regex("No module named '*ipaserver'*"))
|
|
when: ipa_host_is_client
|
|
|
|
- name: Ensuref fail if externalmember is used in client context.
|
|
ipagroup:
|
|
ipaadmin_password: SomeADMINpassword
|
|
ipaapi_context: client
|
|
name: ThisShouldNotWork
|
|
external_member: "{{ ad_user }}"
|
|
external: true
|
|
register: result
|
|
failed_when: not (result.failed and result.msg == "Cannot use externalmember in client context.")
|
|
|
|
# Import basic module tests, and execute with ipa_context set to 'client'.
|
|
# If ipaclients is set, it will be executed using the client, if not,
|
|
# ipaserver will be used.
|
|
#
|
|
# With this setup, tests can be executed against an IPA client, against
|
|
# an IPA server using "client" context, and ensure that tests are executed
|
|
# in upstream CI.
|
|
|
|
- name: Test group using client context, in client host.
|
|
ansible.builtin.import_playbook: test_group.yml
|
|
when: groups['ipaclients']
|
|
vars:
|
|
ipa_test_host: ipaclients
|
|
|
|
- name: Test group using client context, in server host.
|
|
ansible.builtin.import_playbook: test_group.yml
|
|
when: groups['ipaclients'] is not defined or not groups['ipaclients']
|
|
vars:
|
|
ipa_context: client
|
|
|
|
- name: Test groups using client context, in client host.
|
|
ansible.builtin.import_playbook: test_groups.yml
|
|
when: groups['ipaclients']
|
|
vars:
|
|
ipa_test_host: ipaclients
|
|
|
|
- name: Test groups using client context, in server host.
|
|
ansible.builtin.import_playbook: test_groups.yml
|
|
when: groups['ipaclients'] is not defined or not groups['ipaclients']
|
|
vars:
|
|
ipa_context: client
|
|
|
|
- name: Test groups with mixed types using client context, in client host.
|
|
ansible.builtin.import_playbook: test_groups_external_nonposix.yml
|
|
when: groups['ipaclients']
|
|
vars:
|
|
ipa_test_host: ipaclients
|
|
|
|
- name: Test groups with mixed types using client context, in server host.
|
|
ansible.builtin.import_playbook: test_groups_external_nonposix.yml
|
|
when: groups['ipaclients'] is not defined or not groups['ipaclients']
|
|
vars:
|
|
ipa_context: client
|