Add support for missing attributes, and enhance ipaconfig tests.

This patch add support for the attributes `maxtostname` and
`ca_renewal_master_server` attributes that were missing and
also provide a more complete set of tests.

tests/config/test_config.yml

@@ -5,6 +5,7 @@
   gather_facts: false
 
   tasks:
+  # Retrieve current configuration.
   - name: return current values of the global configuration options
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
@@ -13,131 +14,375 @@
   - debug:
       msg: "{{previousconfig}}"
 
-  - name: set default shell to default value
+  # setup environment.
+  - name: create test group
+    ipagroup:
+      ipaadmin_password: 'SomeADMINpassword'
+      name: somedefaultgroup
+
+  - name: Ensure the default e-mail domain is ipa.test.
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      emaildomain: ipa.test
+
+  - name: set default shell to '/bin/sh'
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
       defaultshell: /bin/sh
-    register: result
-    failed_when: result.changed
 
-  - name: set default shell to new value
+  - name: set default group
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      defaultshell: /bin/bash
+      defaultgroup: ipausers
+
+  - name: set default home directory
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      homedirectory: /home
+
+  - name: clear pac-type
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      pac_type: ""
+
+  - name: set maxusername to 255
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      maxusername: 255
+
+  - name: set maxhostname to 255
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      maxhostname: 255
+
+  - name: set pwdexpnotify to 0
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      pwdexpnotify: 0
+
+  - name: set searchrecordslimit to 10
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      searchrecordslimit: 10
+
+  - name: set searchtimelimit to 1
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      searchtimelimit: 1
+
+  - name: clear configstring
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      configstring: ""
+
+  - name: set configstring to AllowNThash
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      configstring: 'KDC:Disable Lockout'
+
+  - name: set selinuxusermapdefault
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      selinuxusermapdefault: "staff_u:s0-s0:c0.c1023"
+
+  - name: set selinuxusermaporder
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      selinuxusermaporder: 'user_u:s0$staff_u:s0-s0:c0.c1023'
+
+  - name: set usersearch to `uid`
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      usersearch: uid
+
+  - name: set groupsearch to `cn`
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      groupsearch: cn
+
+  # tests
+  - name: Ensure the default e-mail domain is somedomain.test.
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      emaildomain: somedomain.test
     register: result
     failed_when: not result.changed
 
-  - name: check default shell is changed
+  - name: Ensure the default e-mail domain is somedomain.test, again.
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      defaultshell: /bin/bash
+      emaildomain: somedomain.test
     register: result
     failed_when: result.changed
 
-  - name: reset default shell to old value
+  - name: set default shell to '/bin/someshell'
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      defaultshell: '{{previousconfig.config.defaultshell }}'
+      defaultshell: /bin/someshell
     register: result
     failed_when: not result.changed
 
-  - name: check default shell is reset
+  - name: set default shell to '/bin/someshell', again.
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      defaultshell: '{{previousconfig.config.defaultshell }}'
+      defaultshell: /bin/someshell
     register: result
     failed_when: result.changed
 
-  - name: Ensure the default e-mail domain is ansible.com.
+  - name: set default group
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      emaildomain: ansible.com
+      defaultgroup: somedefaultgroup
     register: result
     failed_when: not result.changed
 
-  - name: Ensure the default e-mail domain is set
+  - name: set default group
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      emaildomain: ansible.com
+      defaultgroup: somedefaultgroup
     register: result
     failed_when: result.changed
 
-  - name: reset default e-mail domain
+  - name: set default home directory
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      emaildomain: '{{previousconfig.config.emaildomain }}'
+      homedirectory: /Users
     register: result
     failed_when: not result.changed
 
+  - name: set default home directory
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      homedirectory: /Users
+    register: result
+    failed_when: result.changed
+
   - name: set pac-type
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      pac_type:
-        - nfs:NONE
+      pac_type: "nfs:NONE"
     register: result
     failed_when: not result.changed
 
-  - name: reset pac-type
+  - name: set pac-type, again.
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      pac_type: '{{previousconfig.config.pac_type}}'
+      pac_type: "nfs:NONE"
+    register: result
+    failed_when: result.changed
+
+  - name: set maxusername to 33
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      maxusername: 33
     register: result
     failed_when: not result.changed
 
-  - name: set usersearch
+  - name: set maxusername to 33, again.
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      usersearch:
-        - uid
+      maxusername: 33
+    register: result
+    failed_when: result.changed
+
+  - name: set maxhostname to 77
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      maxhostname: 77
     register: result
     failed_when: not result.changed
 
-  - name: check usersearch
+  - name: set maxhostname to 77, again
     ipaconfig:
       ipaadmin_password: SomeADMINpassword
-      usersearch:
-        - uid
+      maxhostname: 77
+    register: result
+    failed_when: result.changed
+
+  - name: set pwdexpnotify to 17
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      pwdexpnotify: 17
+    register: result
+    failed_when: not result.changed
+
+  - name: set pwdexpnotify to 17, again
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      pwdexpnotify: 17
+    register: result
+    failed_when: result.changed
+
+  - name: set searchrecordslimit to -1
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      searchrecordslimit: -1
+    register: result
+    failed_when: not result.changed
+
+  - name: set searchrecordslimit to -1, again.
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      searchrecordslimit: -1
+    register: result
+    failed_when: result.changed
+
+  - name: set searchtimelimit to 12345
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      searchtimelimit: 12345
+    register: result
+    failed_when: not result.changed
+
+  - name: set searchtimelimit to 12345, again.
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      searchtimelimit: 12345
+    register: result
+    failed_when: result.changed
+
+  - name: change enable_migration
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      enable_migration: '{{ not previousconfig.config.enable_migration }}'
+    register: result
+    failed_when: not result.changed
+
+  - name: change enable_migration, again
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      enable_migration: '{{ not previousconfig.config.enable_migration }}'
+    register: result
+    failed_when: result.changed
+
+  - name: set configstring to AllowNThash
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      configstring: AllowNThash
+    register: result
+    failed_when: not result.changed
+
+  - name: set configstring to AllowNThash, again.
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      configstring: AllowNThash
+    register: result
+    failed_when: result.changed
+
+  - name: set selinuxusermaporder
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      selinuxusermaporder: 'user_u:s0$staff_u:s0-s0:c0.c1023$sysadm_u:s0-s0:c0.c1023$unconfined_u:s0-s0:c0.c1023'
+    register: result
+    failed_when: not result.changed
+
+  - name: set selinuxusermaporder, again
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      selinuxusermaporder: 'user_u:s0$staff_u:s0-s0:c0.c1023$sysadm_u:s0-s0:c0.c1023$unconfined_u:s0-s0:c0.c1023'
+    register: result
+    failed_when: result.changed
+
+  - name: set selinuxusermapdefault
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      selinuxusermapdefault: 'user_u:s0'
+    register: result
+    failed_when: not result.changed
+
+  - name: set selinuxusermapdefault, again
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      selinuxusermapdefault: 'user_u:s0'
+    register: result
+    failed_when: result.changed
+
+  - name: set groupsearch to `description`
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      groupsearch: description
+    register: result
+    failed_when: not result.changed
+
+  - name: set groupsearch to `gidNumber`, again
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      groupsearch: description
+    register: result
+    failed_when: result.changed
+
+  - name: set usersearch to `uidNumber`
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      usersearch: uidNumber
+    register: result
+    failed_when: not result.changed
+
+  - name: set usersearch to `uidNumber`, again
+    ipaconfig:
+      ipaadmin_password: SomeADMINpassword
+      usersearch: uidNumber
     register: result
     failed_when: result.changed
 
   - name: reset changed fields
     ipaconfig:
       ipaadmin_password: 'SomeADMINpassword'
-      configstring: '{{previousconfig.config.configstring}}'
-      emaildomain: '{{previousconfig.config.emaildomain}}'
-      defaultshell: '{{previousconfig.config.defaultshell}}'
-      defaultgroup: '{{previousconfig.config.defaultgroup}}'
-      groupsearch: '{{previousconfig.config.groupsearch}}'
-      homedirectory: '{{previousconfig.config.homedirectory}}'
-      pac_type: '{{previousconfig.config.pac_type}}'
-      maxusername: '{{previousconfig.config.maxusername}}'
-      enable_migration: '{{previousconfig.config.enable_migration}}'
-      pwdexpnotify: '{{previousconfig.config.pwdexpnotify}}'
-      searchrecordslimit: '{{previousconfig.config.searchrecordslimit}}'
-      searchtimelimit: '{{previousconfig.config.searchtimelimit}}'
-      selinuxusermapdefault: '{{previousconfig.config.selinuxusermapdefault}}'
-      selinuxusermaporder: '{{previousconfig.config.selinuxusermaporder}}'
-      usersearch: '{{previousconfig.config.usersearch}}'
+      maxusername: '{{previousconfig.config.maxusername | default(omit)}}'
+      maxhostname: '{{previousconfig.config.maxhostname | default(omit)}}'
+      homedirectory: '{{previousconfig.config.homedirectory | default(omit)}}'
+      defaultshell: '{{previousconfig.config.defaultshell | default(omit)}}'
+      defaultgroup: '{{previousconfig.config.defaultgroup | default(omit)}}'
+      emaildomain: '{{previousconfig.config.emaildomain | default(omit)}}'
+      searchtimelimit: '{{previousconfig.config.searchtimelimit | default(omit)}}'
+      searchrecordslimit: '{{previousconfig.config.searchrecordslimit | default(omit)}}'
+      usersearch: '{{previousconfig.config.usersearch | default(omit)}}'
+      groupsearch: '{{previousconfig.config.groupsearch | default(omit)}}'
+      enable_migration: '{{previousconfig.config.enable_migration | default(omit)}}'
+      groupobjectclasses: '{{previousconfig.config.groupobjectclasses | default(omit)}}'
+      userobjectclasses: '{{previousconfig.config.userobjectclasses | default(omit)}}'
+      pwdexpnotify: '{{previousconfig.config.pwdexpnotify | default(omit)}}'
+      configstring: '{{previousconfig.config.configstring | default(omit)}}'
+      selinuxusermapdefault: '{{previousconfig.config.selinuxusermapdefault | default(omit)}}'
+      selinuxusermaporder: '{{previousconfig.config.selinuxusermaporder | default(omit)}}'
+      pac_type: '{{previousconfig.config.pac_type | default(omit)}}'
+      user_auth_type: '{{previousconfig.config.user_auth_type | default(omit)}}'
+      domain_resolution_order: '{{previousconfig.config.domain_resolution_order | default(omit)}}'
+      ca_renewal_master_server: '{{previousconfig.config.ca_renewal_master_server | default(omit)}}'
     register: result
     failed_when: not result.changed
 
-  - name: check reset fields
+  - name: reset changed fields, again
     ipaconfig:
       ipaadmin_password: 'SomeADMINpassword'
-      configstring: '{{previousconfig.config.configstring}}'
-      emaildomain: '{{previousconfig.config.emaildomain}}'
-      defaultshell: '{{previousconfig.config.defaultshell}}'
-      defaultgroup: '{{previousconfig.config.defaultgroup}}'
-      groupsearch: '{{previousconfig.config.groupsearch}}'
-      homedirectory: '{{previousconfig.config.homedirectory}}'
-      pac_type: '{{previousconfig.config.pac_type}}'
-      maxusername: '{{previousconfig.config.maxusername}}'
-      enable_migration: '{{previousconfig.config.enable_migration}}'
-      pwdexpnotify: '{{previousconfig.config.pwdexpnotify}}'
-      searchrecordslimit: '{{previousconfig.config.searchrecordslimit}}'
-      searchtimelimit: '{{previousconfig.config.searchtimelimit}}'
-      selinuxusermapdefault: '{{previousconfig.config.selinuxusermapdefault}}'
-      selinuxusermaporder: '{{previousconfig.config.selinuxusermaporder}}'
-      usersearch: '{{previousconfig.config.usersearch}}'
+      maxusername: '{{previousconfig.config.maxusername | default(omit)}}'
+      maxhostname: '{{previousconfig.config.maxhostname | default(omit)}}'
+      homedirectory: '{{previousconfig.config.homedirectory | default(omit)}}'
+      defaultshell: '{{previousconfig.config.defaultshell | default(omit)}}'
+      defaultgroup: '{{previousconfig.config.defaultgroup | default(omit)}}'
+      emaildomain: '{{previousconfig.config.emaildomain | default(omit)}}'
+      searchtimelimit: '{{previousconfig.config.searchtimelimit | default(omit)}}'
+      searchrecordslimit: '{{previousconfig.config.searchrecordslimit | default(omit)}}'
+      usersearch: '{{previousconfig.config.usersearch | default(omit)}}'
+      groupsearch: '{{previousconfig.config.groupsearch | default(omit)}}'
+      enable_migration: '{{previousconfig.config.enable_migration | default(omit)}}'
+      groupobjectclasses: '{{previousconfig.config.groupobjectclasses | default(omit)}}'
+      userobjectclasses: '{{previousconfig.config.userobjectclasses | default(omit)}}'
+      pwdexpnotify: '{{previousconfig.config.pwdexpnotify | default(omit)}}'
+      configstring: '{{previousconfig.config.configstring | default(omit)}}'
+      selinuxusermapdefault: '{{previousconfig.config.selinuxusermapdefault | default(omit)}}'
+      selinuxusermaporder: '{{previousconfig.config.selinuxusermaporder | default(omit)}}'
+      pac_type: '{{previousconfig.config.pac_type | default(omit)}}'
+      user_auth_type: '{{previousconfig.config.user_auth_type | default(omit)}}'
+      domain_resolution_order: '{{previousconfig.config.domain_resolution_order | default(omit)}}'
+      ca_renewal_master_server: '{{previousconfig.config.ca_renewal_master_server | default(omit)}}'
     register: result
     failed_when: result.changed
+
+  # cleanup
+
+  - name: cleanup test group
+    ipagroup:
+      ipaadmin_password: 'SomeADMINpassword'
+      name: somedefaultgroup
+      state: absent