test_config.yml: Use result.failed also for failed_when

For failed_when result.failed should be used to make sure that
the task fails if there was an error.
This commit is contained in:
Thomas Woerner
2021-05-20 13:16:07 +02:00
parent a30d8a27eb
commit eb5c12f136

View File

@@ -110,84 +110,84 @@
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
emaildomain: somedomain.test emaildomain: somedomain.test
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Ensure the default e-mail domain is somedomain.test, again. - name: Ensure the default e-mail domain is somedomain.test, again.
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
emaildomain: somedomain.test emaildomain: somedomain.test
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set default shell to '/bin/someshell' - name: set default shell to '/bin/someshell'
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
defaultshell: /bin/someshell defaultshell: /bin/someshell
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set default shell to '/bin/someshell', again. - name: set default shell to '/bin/someshell', again.
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
defaultshell: /bin/someshell defaultshell: /bin/someshell
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set default group - name: set default group
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
defaultgroup: somedefaultgroup defaultgroup: somedefaultgroup
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set default group - name: set default group, again
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
defaultgroup: somedefaultgroup defaultgroup: somedefaultgroup
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set default home directory - name: set default home directory
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
homedirectory: /Users homedirectory: /Users
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set default home directory - name: set default home directory, again
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
homedirectory: /Users homedirectory: /Users
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set pac-type - name: set pac-type
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
pac_type: "nfs:NONE" pac_type: "nfs:NONE"
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set pac-type, again. - name: set pac-type, again.
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
pac_type: "nfs:NONE" pac_type: "nfs:NONE"
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set maxusername to 33 - name: set maxusername to 33
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
maxusername: 33 maxusername: 33
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set maxusername to 33, again. - name: set maxusername to 33, again.
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
maxusername: 33 maxusername: 33
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set maxhostname to 77 - name: set maxhostname to 77
block: block:
@@ -195,13 +195,13 @@
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
maxhostname: 77 maxhostname: 77
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- ipaconfig: - ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
maxhostname: 77 maxhostname: 77
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
when: ipa_version is version('4.8.0', '>=') when: ipa_version is version('4.8.0', '>=')
- name: set pwdexpnotify to 17 - name: set pwdexpnotify to 17
@@ -209,126 +209,126 @@
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
pwdexpnotify: 17 pwdexpnotify: 17
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set pwdexpnotify to 17, again - name: set pwdexpnotify to 17, again
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
pwdexpnotify: 17 pwdexpnotify: 17
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set searchrecordslimit to -1 - name: set searchrecordslimit to -1
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
searchrecordslimit: -1 searchrecordslimit: -1
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set searchrecordslimit to -1, again. - name: set searchrecordslimit to -1, again.
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
searchrecordslimit: -1 searchrecordslimit: -1
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set searchtimelimit to 12345 - name: set searchtimelimit to 12345
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
searchtimelimit: 12345 searchtimelimit: 12345
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set searchtimelimit to 12345, again. - name: set searchtimelimit to 12345, again.
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
searchtimelimit: 12345 searchtimelimit: 12345
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: change enable_migration - name: change enable_migration
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
enable_migration: '{{ not previousconfig.config.enable_migration }}' enable_migration: '{{ not previousconfig.config.enable_migration }}'
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: change enable_migration, again - name: change enable_migration, again
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
enable_migration: '{{ not previousconfig.config.enable_migration }}' enable_migration: '{{ not previousconfig.config.enable_migration }}'
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set configstring to AllowNThash - name: set configstring to AllowNThash
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
configstring: AllowNThash configstring: AllowNThash
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set configstring to AllowNThash, again. - name: set configstring to AllowNThash, again.
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
configstring: AllowNThash configstring: AllowNThash
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set selinuxusermaporder - name: set selinuxusermaporder
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
selinuxusermaporder: 'user_u:s0$staff_u:s0-s0:c0.c1023$sysadm_u:s0-s0:c0.c1023$unconfined_u:s0-s0:c0.c1023' selinuxusermaporder: 'user_u:s0$staff_u:s0-s0:c0.c1023$sysadm_u:s0-s0:c0.c1023$unconfined_u:s0-s0:c0.c1023'
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set selinuxusermaporder, again - name: set selinuxusermaporder, again
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
selinuxusermaporder: 'user_u:s0$staff_u:s0-s0:c0.c1023$sysadm_u:s0-s0:c0.c1023$unconfined_u:s0-s0:c0.c1023' selinuxusermaporder: 'user_u:s0$staff_u:s0-s0:c0.c1023$sysadm_u:s0-s0:c0.c1023$unconfined_u:s0-s0:c0.c1023'
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set selinuxusermapdefault - name: set selinuxusermapdefault
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
selinuxusermapdefault: 'user_u:s0' selinuxusermapdefault: 'user_u:s0'
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set selinuxusermapdefault, again - name: set selinuxusermapdefault, again
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
selinuxusermapdefault: 'user_u:s0' selinuxusermapdefault: 'user_u:s0'
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set groupsearch to `description` - name: set groupsearch to `description`
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
groupsearch: description groupsearch: description
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set groupsearch to `gidNumber`, again - name: set groupsearch to `gidNumber`, again
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
groupsearch: description groupsearch: description
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: set usersearch to `uidNumber` - name: set usersearch to `uidNumber`
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
usersearch: uidNumber usersearch: uidNumber
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: set usersearch to `uidNumber`, again - name: set usersearch to `uidNumber`, again
ipaconfig: ipaconfig:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
usersearch: uidNumber usersearch: uidNumber
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: reset changed fields - name: reset changed fields
ipaconfig: ipaconfig:
@@ -354,7 +354,7 @@
domain_resolution_order: '{{previousconfig.config.domain_resolution_order | default(omit)}}' domain_resolution_order: '{{previousconfig.config.domain_resolution_order | default(omit)}}'
ca_renewal_master_server: '{{previousconfig.config.ca_renewal_master_server | default(omit)}}' ca_renewal_master_server: '{{previousconfig.config.ca_renewal_master_server | default(omit)}}'
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: reset maxhostname - name: reset maxhostname
block: block:
@@ -387,7 +387,7 @@
domain_resolution_order: '{{previousconfig.config.domain_resolution_order | default(omit)}}' domain_resolution_order: '{{previousconfig.config.domain_resolution_order | default(omit)}}'
ca_renewal_master_server: '{{previousconfig.config.ca_renewal_master_server | default(omit)}}' ca_renewal_master_server: '{{previousconfig.config.ca_renewal_master_server | default(omit)}}'
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: reset maxhostname - name: reset maxhostname
block: block: