internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-25 00:44:42 +00:00
Code Issues Projects Releases Wiki Activity

utils/templates/ipamodule+member.py.in: Use execute_ipa_commands

Browse Source 
execute_ipa_commands replces the check mode exit, the loop over the
generated commands and also in the member failure handling for modules
with member support.
This commit is contained in:
Thomas Woerner
2021-09-07 11:21:32 +02:00
parent 5c38d43ce3
commit e897ecb27a
1 changed files with 25 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
utils/templates/ipamodule+member.py.in
View File

@@ -286,38 +286,34 @@ def main():
else: else:
ansible_module.fail_json(msg="Unkown state '%s'" % state) ansible_module.fail_json(msg="Unkown state '%s'" % state)
# Check mode exit
if ansible_module.check_mode:
ansible_module.exit_json(changed=len(commands) > 0, **exit_args)
# Execute commands # Execute commands
for name, command, args in commands: #
try: # To handle default member errors there is a static method
result = ansible_module.ipa_command(command, name, args) # IPAAnsibleModule.handle_member_errors. It can be enabled with
if "completed" in result: # fail_on_member_failures=True for execute_ipa_commands.
if result["completed"] > 0: # There might be cases in which this needs to be either done
changed = True # manually or extended.
else: #
changed = True # Example:
except Exception as e: #
ansible_module.fail_json(msg="%s: %s: %s" % (command, name, # pylint: disable=unused-argument
str(e))) # def result_handler(module, result, command, name, args, errors):
# Get all errors # # Get all errors
# All "already a member" and "not a member" failures in the # IPAAnsibleModule.handle_member_errors(module, result, command,
# result are ignored. All others are reported. # name, args, errors)
errors = [] # if "MY ERROR" in result.get("failed",[]):
for failed_item in result.get("failed", []): # errors.append("My error")
failed = result["failed"][failed_item] #
for member_type in failed: # # Execute commands
for member, failure in failed[member_type]: #
if "already a member" in failure \ # changed = ansible_module.execute_ipa_commands(commands,
or "not a member" in failure: # result_handler)
continue #
errors.append("%s: %s %s: %s" % (
command, member_type, member, failure)) changed = ansible_module.execute_ipa_commands(
if len(errors) > 0: commands, fail_on_member_failures=True)
ansible_module.fail_json(msg=", ".join(errors))
# Done # Done