test_user_certificate.yml: Use result.failed also for failed_when

For failed_when result.failed should be used to make sure that
the task fails if there was an error.

Fixed also "User test cert members present again" task, it was failing
due to also having first and last parameters with action: member.
This commit is contained in:
Thomas Woerner
2021-05-20 13:16:42 +02:00
parent ed146a4fcf
commit e0defaaebe

View File

@@ -32,21 +32,19 @@
- "{{ lookup('file', 'cert3.b64', rstrip=False) }}" - "{{ lookup('file', 'cert3.b64', rstrip=False) }}"
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: User test cert members present again - name: User test cert members present again
ipauser: ipauser:
ipaadmin_password: SomeADMINpassword ipaadmin_password: SomeADMINpassword
name: test name: test
first: test
last: test
certificate: certificate:
- "{{ lookup('file', 'cert1.b64', rstrip=False) }}" - "{{ lookup('file', 'cert1.b64', rstrip=False) }}"
- "{{ lookup('file', 'cert2.b64', rstrip=False) }}" - "{{ lookup('file', 'cert2.b64', rstrip=False) }}"
- "{{ lookup('file', 'cert3.b64', rstrip=False) }}" - "{{ lookup('file', 'cert3.b64', rstrip=False) }}"
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: User test cert members absent - name: User test cert members absent
ipauser: ipauser:
@@ -59,7 +57,7 @@
state: absent state: absent
action: member action: member
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: User test cert members absent again - name: User test cert members absent again
ipauser: ipauser:
@@ -72,7 +70,7 @@
state: absent state: absent
action: member action: member
register: result register: result
failed_when: result.changed failed_when: result.changed or result.failed
- name: User test absent - name: User test absent
ipauser: ipauser:
@@ -80,7 +78,7 @@
name: test name: test
state: absent state: absent
register: result register: result
failed_when: not result.changed failed_when: not result.changed or result.failed
- name: Remove certificate files. - name: Remove certificate files.
shell: shell: