mirror of
https://github.com/freeipa/ansible-freeipa.git
synced 2026-07-29 19:04:42 +00:00
Fixed automountkey code review issues.
Fixed several issues found during code review and change AutomountkeyModule to use IPAAnsibleModule instead of deprecated FreeIPABaseModule.
This commit is contained in:
Rafael Guterres Jeffman
@@ -1,180 +1,154 @@
|
||||
---
|
||||
- name: Test automountmap
|
||||
hosts: ipaserver
|
||||
become: true
|
||||
gather_facts: false
|
||||
hosts: "{{ ipa_test_host | default('ipaserver') }}"
|
||||
become: no
|
||||
gather_facts: no
|
||||
|
||||
tasks:
|
||||
- name: ensure location TestLocation is absent
|
||||
- name: ensure test location TestLocation is present
|
||||
ipaautomountlocation:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
name: TestLocation
|
||||
state: absent
|
||||
|
||||
# - name: ensure map TestMap is absent
|
||||
# ipaautomountmap:
|
||||
# ipaadmin_password: SomeADMINpassword
|
||||
# name: TestMap
|
||||
# location: TestLocation
|
||||
# state: absent
|
||||
#
|
||||
# - name: ensure key TestKey is absent
|
||||
# ipaautomountkey:
|
||||
# ipaadmin_password: SomeADMINpassword
|
||||
# automountlocationcn: TestLocation
|
||||
# automountmapname: TestMap
|
||||
# automountkey: TestKey
|
||||
# state: absent
|
||||
|
||||
- name: create location TestLocation
|
||||
ipaautomountlocation:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
name: TestLocation
|
||||
state: present
|
||||
|
||||
- name: create map TestMap
|
||||
- name: ensure test map TestMap is present
|
||||
ipaautomountmap:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
name: TestMap
|
||||
location: TestLocation
|
||||
desc: "this is a test map that should be deleted by the test"
|
||||
|
||||
### test the key creation, and modification
|
||||
- name: ensure key TestKey is present
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: TestKey
|
||||
automountinformation: 192.168.122.1:/exports
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or not result.changed
|
||||
|
||||
- name: ensure key TestKey is present again
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: TestKey
|
||||
automountinformation: 192.168.122.1:/exports
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
## modify the key
|
||||
- name: ensure key TestKey information has been updated
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: TestKey
|
||||
automountinformation: 192.168.122.1:/nfsshare
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or not result.changed
|
||||
|
||||
- name: ensure key TestKey information has been updated again
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: TestKey
|
||||
automountinformation: 192.168.122.1:/nfsshare
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
## modify the name
|
||||
- name: ensure key TestKey has been renamed to NewKeyName
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: TestKey
|
||||
automountinformation: 192.168.122.1:/nfsshare
|
||||
newname: NewKeyName
|
||||
state: rename
|
||||
register: result
|
||||
failed_when: result.failed or not result.changed
|
||||
|
||||
- name: ensure key TestKey does not exist
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: NewKeyName
|
||||
automountinformation: 192.168.122.1:/nfsshare
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
- name: ensure key NewKeyName does exist
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: NewKeyName
|
||||
automountinformation: 192.168.122.1:/nfsshare
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
- name: ensure key TestKey has been renamed to NewKeyName again
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: TestKey
|
||||
automountinformation: 192.168.122.1:/nfsshare
|
||||
newname: NewKeyName
|
||||
state: rename
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
- name: ensure failure when state=present and newname is not set
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: TestKey
|
||||
automountinformation: 192.168.122.1:/nfsshare
|
||||
state: rename
|
||||
register: result
|
||||
failed_when: not result.failed
|
||||
|
||||
|
||||
### cleanup after the tests
|
||||
- name: ensure key NewKeyName is absent
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: NewKeyName
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: NewKeyName
|
||||
state: absent
|
||||
register: result
|
||||
failed_when: result.failed or not result.changed
|
||||
|
||||
- name: ensure key TestKey is absent again
|
||||
- name: ensure key TestKey is absent
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
automountlocationcn: TestLocation
|
||||
automountmapname: TestMap
|
||||
automountkey: NewKeyName
|
||||
state: absent
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
- name: ensure map TestMap is removed
|
||||
ipaautomountmap:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
name: TestMap
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: NewKeyName
|
||||
state: absent
|
||||
|
||||
- name: ensure location TestLocation is removed
|
||||
ipaautomountlocation:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
name: TestLocation
|
||||
state: absent
|
||||
- block:
|
||||
### test the key creation, and modification
|
||||
- name: ensure key TestKey is present
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: TestKey
|
||||
info: 192.168.122.1:/exports
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or not result.changed
|
||||
|
||||
- name: ensure key TestKey is present again
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: TestKey
|
||||
info: 192.168.122.1:/exports
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
## modify the key
|
||||
- name: ensure key TestKey information has been updated
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: TestKey
|
||||
info: 192.168.122.1:/nfsshare
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or not result.changed
|
||||
|
||||
- name: ensure key TestKey information has been updated again
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: TestKey
|
||||
info: 192.168.122.1:/nfsshare
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
## modify the name
|
||||
- name: ensure key TestKey has been renamed to NewKeyName
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: TestKey
|
||||
new_name: NewKeyName
|
||||
state: renamed
|
||||
register: result
|
||||
failed_when: result.failed or not result.changed
|
||||
|
||||
- name: ensure key TestKey is absent
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: TestKey
|
||||
state: absent
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
- name: ensure key NewKeyName is present
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: NewKeyName
|
||||
info: 192.168.122.1:/nfsshare
|
||||
state: present
|
||||
register: result
|
||||
failed_when: result.failed or result.changed
|
||||
|
||||
- name: ensure failure when state is renamed and newname is not set
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: TestKey
|
||||
state: renamed
|
||||
register: result
|
||||
failed_when: not result.failed
|
||||
|
||||
### cleanup after the tests
|
||||
always:
|
||||
- name: ensure key NewKeyName is absent
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: NewKeyName
|
||||
state: absent
|
||||
|
||||
- name: ensure key TestKey is absent
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
location: TestLocation
|
||||
map: TestMap
|
||||
key: NewKeyName
|
||||
state: absent
|
||||
|
||||
- name: ensure map TestMap is absent
|
||||
ipaautomountmap:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
name: TestMap
|
||||
location: TestLocation
|
||||
state: absent
|
||||
|
||||
- name: ensure location TestLocation is absent
|
||||
ipaautomountlocation:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
name: TestLocation
|
||||
state: absent
|
||||
|
||||
41
tests/automount/test_automountkey_client_context.yml
Normal file
41
tests/automount/test_automountkey_client_context.yml
Normal file
@@ -0,0 +1,41 @@
|
||||
---
|
||||
- name: Test automountkey
|
||||
hosts: ipaclients, ipaserver
|
||||
become: no
|
||||
gather_facts: no
|
||||
|
||||
tasks:
|
||||
- name: Include FreeIPA facts.
|
||||
include_tasks: ../env_freeipa_facts.yml
|
||||
|
||||
# Test will only be executed if host is not a server.
|
||||
- name: Execute with server context in the client.
|
||||
ipaautomountkey:
|
||||
ipaadmin_password: SomeADMINpassword
|
||||
ipaapi_context: server
|
||||
location: NoLocation
|
||||
map: NoMap
|
||||
key: ThisShouldNotWork
|
||||
register: result
|
||||
failed_when: not (result.failed and result.msg is regex("No module named '*ipaserver'*"))
|
||||
when: ipa_host_is_client
|
||||
|
||||
# Import basic module tests, and execute with ipa_context set to 'client'.
|
||||
# If ipaclients is set, it will be executed using the client, if not,
|
||||
# ipaserver will be used.
|
||||
#
|
||||
# With this setup, tests can be executed against an IPA client, against
|
||||
# an IPA server using "client" context, and ensure that tests are executed
|
||||
# in upstream CI.
|
||||
|
||||
- name: Test automountlocation using client context, in client host.
|
||||
import_playbook: test_automountkey.yml
|
||||
when: groups['ipaclients']
|
||||
vars:
|
||||
ipa_test_host: ipaclients
|
||||
|
||||
- name: Test automountlocation using client context, in server host.
|
||||
import_playbook: test_automountkey.yml
|
||||
when: groups['ipaclients'] is not defined or not groups['ipaclients']
|
||||
vars:
|
||||
ipa_context: client
|
||||
Reference in New Issue
Block a user