internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-30 11:24:50 +00:00
Code Issues Projects Releases Wiki Activity

idoverideuser: Use module.params_get_type

Browse Source 
Use the commom parameter type handling method for parameters that accept
a value or an empty string.
This commit is contained in:
Rafael Guterres Jeffman
2023-09-17 22:34:48 -03:00
parent 92d579be41
commit bc694b722c
1 changed files with 2 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/modules/ipaidoverrideuser.py
View File

@@ -439,9 +439,9 @@ def main():
# present # present
description = ansible_module.params_get("description") description = ansible_module.params_get("description")
name = ansible_module.params_get("name") name = ansible_module.params_get("name")
uid = ansible_module.params_get("uid") uid = ansible_module.params_get_with_type_cast("uid", int)
gecos = ansible_module.params_get("gecos") gecos = ansible_module.params_get("gecos")
gidnumber = ansible_module.params_get("gidnumber") gidnumber = ansible_module.params_get_with_type_cast("gidnumber", int)
homedir = ansible_module.params_get("homedir") homedir = ansible_module.params_get("homedir")
shell = ansible_module.params_get("shell") shell = ansible_module.params_get("shell")
sshpubkey = ansible_module.params_get("sshpubkey") sshpubkey = ansible_module.params_get("sshpubkey")
@@ -479,20 +479,6 @@ def main():
ansible_module.params_fail_used_invalid(invalid, state, action) ansible_module.params_fail_used_invalid(invalid, state, action)
# Ensure parameter values are valid and have proper type.
def int_or_empty_param(value, param):
if value is not None and value != "":
try:
value = int(value)
except ValueError:
ansible_module.fail_json(
msg="Invalid value '%s' for argument '%s'" % (value, param)
)
return value
uid = int_or_empty_param(uid, "uid")
gidnumber = int_or_empty_param(gidnumber, "gidnumber")
if certificate is not None: if certificate is not None:
certificate = [cert.strip() for cert in certificate] certificate = [cert.strip() for cert in certificate]