test_dnsforwardzone.yml: Use result.failed also for failed_when

For failed_when result.failed should be used to make sure that
the task fails if there was an error.
This commit is contained in:
Thomas Woerner
2021-05-20 13:16:09 +02:00
parent 7f0d367f78
commit b6cbc4d7f3

View File

@@ -23,7 +23,7 @@
forwardpolicy: first
skip_overlap_check: true
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: ensure forwardzone example.com is present again
ipadnsforwardzone:
@@ -35,7 +35,7 @@
forwardpolicy: first
skip_overlap_check: true
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: ensure forwardzone example.com has two forwarders
ipadnsforwardzone:
@@ -49,7 +49,7 @@
forwardpolicy: first
skip_overlap_check: true
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: ensure forwardzone example.com has one forwarder again
ipadnsforwardzone:
@@ -61,7 +61,7 @@
skip_overlap_check: true
state: present
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: skip_overlap_check can only be set on creation so change nothing
ipadnsforwardzone:
@@ -73,7 +73,7 @@
skip_overlap_check: false
state: present
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: ensure forwardzone example.com is absent.
ipadnsforwardzone:
@@ -81,7 +81,7 @@
name: example.com
state: absent
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: ensure forwardzone example.com is absent, again.
ipadnsforwardzone:
@@ -89,7 +89,7 @@
name: example.com
state: absent
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: change all the things at once
ipadnsforwardzone:
@@ -104,7 +104,7 @@
skip_overlap_check: true
permission: yes
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: change zone forward policy
ipadnsforwardzone:
@@ -112,7 +112,7 @@
name: example.com
forwardpolicy: first
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: change zone forward policy, again
ipadnsforwardzone:
@@ -120,7 +120,7 @@
name: example.com
forwardpolicy: first
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: ensure forwardzone example.com is absent.
ipadnsforwardzone:
@@ -147,7 +147,7 @@
forwarders:
- ip_address: 8.8.8.8
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: ensure forwardzone example.com is created with minimal args, again
ipadnsforwardzone:
@@ -170,7 +170,7 @@
port: 8053
action: member
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: add a forwarder to any existing ones, again
ipadnsforwardzone:
@@ -195,7 +195,7 @@
- ip_address: 8.8.8.8
action: member
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: remove a single forwarder
ipadnsforwardzone:
@@ -206,7 +206,7 @@
- ip_address: 8.8.8.8
action: member
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: remove a single forwarder, again
ipadnsforwardzone:
@@ -229,7 +229,7 @@
port: 8053
action: member
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: Add a permission for per-forward zone access delegation.
ipadnsforwardzone:
@@ -238,7 +238,7 @@
permission: yes
action: member
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: Add a permission for per-forward zone access delegation, again.
ipadnsforwardzone:
@@ -247,7 +247,7 @@
permission: yes
action: member
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: Remove a permission for per-forward zone access delegation.
ipadnsforwardzone:
@@ -256,7 +256,7 @@
permission: no
action: member
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: Remove a permission for per-forward zone access delegation, again.
ipadnsforwardzone:
@@ -265,7 +265,7 @@
permission: no
action: member
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: disable the forwarder
ipadnsforwardzone:
@@ -273,7 +273,7 @@
name: example.com
state: disabled
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: disable the forwarder again
ipadnsforwardzone:
@@ -281,7 +281,7 @@
name: example.com
state: disabled
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: enable the forwarder
ipadnsforwardzone:
@@ -289,7 +289,7 @@
name: example.com
state: enabled
register: result
failed_when: not result.changed
failed_when: not result.changed or result.failed
- name: enable the forwarder, again
ipadnsforwardzone:
@@ -297,7 +297,7 @@
name: example.com
state: enabled
register: result
failed_when: result.changed
failed_when: result.changed or result.failed
- name: ensure forwardzone example.com is absent again
ipadnsforwardzone: