ipaservice: Make tests more robust by testing result.failed.

This patch enables test failure report when result.failed is set,
and make tests more robust against environment differences.

tests/service/test_service_without_skip_host_check.yml

@@ -24,14 +24,14 @@
       ok_as_delegate: no
       ok_to_auth_as_delegate: no
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service is present, again
     ipaservice:
       ipaadmin_password: SomeADMINpassword
       name: "HTTP/{{ svc_fqdn }}"
       pac_type:
-        - MS_PAC
+        - MS-PAC
         - PAD
       auth_ind: otp
       force: no
@@ -39,7 +39,7 @@
       ok_as_delegate: no
       ok_to_auth_as_delegate: no
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Modify service.
     ipaservice:
@@ -49,7 +49,7 @@
       ok_as_delegate: yes
       ok_to_auth_as_delegate: yes
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Modify service, again.
     ipaservice:
@@ -59,7 +59,7 @@
       ok_as_delegate: yes
       ok_to_auth_as_delegate: yes
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Ensure service is present, with host not in DNS.
     ipaservice:
@@ -67,7 +67,7 @@
       name: HTTP/svc.ihavenodns.info
       force: yes
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service is present, with host not in DNS, again.
     ipaservice:
@@ -75,7 +75,7 @@
       name: HTTP/svc.ihavenodns.info
       force: yes
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Principal host/test.example.com present in service.
     ipaservice:
@@ -85,9 +85,9 @@
         - host/test.example.com
       action: member
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
-  - name: Principal host/test.exabple.com present in service, again.
+  - name: Principal host/test.example.com present in service, again.
     ipaservice:
       ipaadmin_password: SomeADMINpassword
       name: "HTTP/{{ svc_fqdn }}"
@@ -95,7 +95,8 @@
         - host/test.example.com
       action: member
     register: result
-    failed_when: result.changed
+    failed_when:
+      result.changed or (result.failed and "already contains one or more values" not in result.msg)
 
   - name: Principal host/test.example.com absent in service.
     ipaservice:
@@ -106,7 +107,7 @@
       action: member
       state: absent
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Principal host/test.example.com absent in service, again.
     ipaservice:
@@ -117,7 +118,8 @@
       action: member
       state: absent
     register: result
-    failed_when: result.changed
+    failed_when:
+      result.changed or (result.failed and "does not contain 'one or more values to remove'" not in result.msg)
 
   - name: Ensure host can manage service.
     ipaservice:
@@ -128,7 +130,7 @@
       - "{{ host2_fqdn }}"
       action: member
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure host can manage service, again.
     ipaservice:
@@ -137,7 +139,7 @@
       host: "{{ host1_fqdn }}"
       action: member
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Ensure host cannot manage service.
     ipaservice:
@@ -149,7 +151,7 @@
       action: member
       state: absent
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure host cannot manage service, again.
     ipaservice:
@@ -161,7 +163,7 @@
       action: member
       state: absent
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Service "HTTP/{{ svc_fqdn }}" members allow_create_keytab present for users, groups, hosts and hostgroups.
     ipaservice:
@@ -181,7 +183,7 @@
       - hostgroup02
       action: member
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Service "HTTP/{{ svc_fqdn }}" members allow_create_keytab present for users, groups, hosts and hostgroups, again.
     ipaservice:
@@ -201,7 +203,7 @@
       - hostgroup02
       action: member
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Service "HTTP/{{ svc_fqdn }}" members allow_create_keytab absent for users, groups, hosts and hostgroups.
     ipaservice:
@@ -222,7 +224,7 @@
       action: member
       state: absent
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Service "HTTP/{{ svc_fqdn }}" members allow_create_keytab absent for users, groups, hosts and hostgroups, again.
     ipaservice:
@@ -243,7 +245,7 @@
       action: member
       state: absent
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Service "HTTP/{{ svc_fqdn }}" members allow_retrieve_keytab present for users, groups, hosts and hostgroups
     ipaservice:
@@ -263,7 +265,7 @@
       - hostgroup02
       action: member
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Service "HTTP/{{ svc_fqdn }}" members allow_retrieve_keytab present for users, groups, hosts and hostgroups, again.
     ipaservice:
@@ -283,7 +285,7 @@
       - hostgroup02
       action: member
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Service "HTTP/{{ svc_fqdn }}" members allow_retrieve_keytab absent for users, groups, hosts and hostgroups.
     ipaservice:
@@ -304,7 +306,7 @@
       action: member
       state: absent
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Service "HTTP/{{ svc_fqdn }}" members allow_retrieve_keytab absent for users, groups, hosts and hostgroups, again.
     ipaservice:
@@ -325,16 +327,17 @@
       action: member
       state: absent
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   #
   - name: Ensure service is absent
     ipaservice:
       ipaadmin_password: SomeADMINpassword
       name: "HTTP/{{ svc_fqdn }}"
+      continue: yes
       state: absent
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service is absent, again
     ipaservice:
@@ -342,7 +345,7 @@
       name: "HTTP/{{ svc_fqdn }}"
       state: absent
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   # cleanup
   - name: Cleanup test environment