ipaservice: Make tests more robust by testing result.failed.

This patch enables test failure report when result.failed is set,
and make tests more robust against environment differences.

tests/service/certificate/test_service_certificate.yml

@@ -58,6 +58,7 @@
     ipaservice:
       ipaadmin_password: SomeADMINpassword
       name: "HTTP/{{ test_host }}"
+      continue: yes
       state: absent
 
   # tests
@@ -76,7 +77,7 @@
       ok_as_delegate: no
       ok_to_auth_as_delegate: no
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service is present, again
     ipaservice:
@@ -85,7 +86,7 @@
       certificate:
         - "{{ lookup('file', 'cert1.b64') }}"
       pac_type:
-        - MS_PAC
+        - MS-PAC
         - PAD
       auth_ind: otp
       force: no
@@ -93,7 +94,7 @@
       ok_as_delegate: no
       ok_to_auth_as_delegate: no
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Ensure service is disabled
     ipaservice:
@@ -101,7 +102,7 @@
       name: "HTTP/{{ test_host }}"
       state: disabled
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service member certificate is present.
     ipaservice:
@@ -112,7 +113,7 @@
       action: member
       state: present
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service member certificate is present, again.
     ipaservice:
@@ -123,7 +124,7 @@
       action: member
       state: present
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Ensure service multiple member certificates are present, with duplicate.
     ipaservice:
@@ -135,7 +136,7 @@
       action: member
       state: present
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service member certificate is absent.
     ipaservice:
@@ -146,7 +147,7 @@
       action: member
       state: absent
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service member certificate is absent, again.
     ipaservice:
@@ -157,7 +158,7 @@
       action: member
       state: absent
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   - name: Ensure service member certificates are absent.
     ipaservice:
@@ -169,7 +170,7 @@
       action: member
       state: absent
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service multiple member certificates is present.
     ipaservice:
@@ -180,7 +181,7 @@
       action: member
       state: present
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service is disabled
     ipaservice:
@@ -188,7 +189,7 @@
       name: "HTTP/{{ test_host }}"
       state: disabled
     register: result
-    failed_when: not result.changed
+    failed_when: not result.changed or result.failed
 
   - name: Ensure service is disabled, again.
     ipaservice:
@@ -196,13 +197,14 @@
       name: "HTTP/{{ test_host }}"
       state: disabled
     register: result
-    failed_when: result.changed
+    failed_when: result.changed or result.failed
 
   # cleanup
   - name: Ensure services are absent.
     ipaservice:
       ipaadmin_password: SomeADMINpassword
       name: "HTTP/{{ test_host }}"
+      continue: yes
       state: absent
 
   - name: Ensure host is absent