internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-30 19:34:45 +00:00
Code Issues Projects Releases Wiki Activity

hbacsvcgroup: Use IPAAnsibleModule class

Browse Source 
ipaadmin_variables are handled by IPAAnsibleModule,
ansible_module.params_get is used to get the parameters and
ansible_module.ipa_connect is used to simplify the module.
This commit is contained in:
Thomas Woerner
2021-08-27 15:00:04 +02:00
parent 7d2bdd7138
commit 9d4572be63
1 changed files with 23 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

75
plugins/modules/ipahbacsvcgroup.py
View File

@@ -32,13 +32,9 @@ DOCUMENTATION = """
module: ipahbacsvcgroup module: ipahbacsvcgroup
short description: Manage FreeIPA hbacsvcgroups short description: Manage FreeIPA hbacsvcgroups
description: Manage FreeIPA hbacsvcgroups description: Manage FreeIPA hbacsvcgroups
extends_documentation_fragment:
- ipamodule_base_docs
options: options:
ipaadmin_principal:
description: The admin principal
default: admin
ipaadmin_password:
description: The admin password
required: false
name: name:
description: The hbacsvcgroup name description: The hbacsvcgroup name
required: false required: false
@@ -101,20 +97,17 @@ EXAMPLES = """
RETURN = """ RETURN = """
""" """
from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.ansible_freeipa_module import \
from ansible.module_utils._text import to_text IPAAnsibleModule, compare_args_ipa, gen_add_del_lists
from ansible.module_utils.ansible_freeipa_module import temp_kinit, \
temp_kdestroy, valid_creds, api_connect, api_command, compare_args_ipa, \
gen_add_del_lists
def find_hbacsvcgroup(module, name): def find_hbacsvcgroup(module, name):
_args = { _args = {
"all": True, "all": True,
"cn": to_text(name), "cn": name,
} }
_result = api_command(module, "hbacsvcgroup_find", to_text(name), _args) _result = module.ipa_command("hbacsvcgroup_find", name, _args)
if len(_result["result"]) > 1: if len(_result["result"]) > 1:
module.fail_json( module.fail_json(
@@ -128,7 +121,7 @@ def find_hbacsvcgroup(module, name):
def gen_args(description, nomembers): def gen_args(description, nomembers):
_args = {} _args = {}
if description is not None: if description is not None:
_args["description"] = to_text(description) _args["description"] = description
if nomembers is not None: if nomembers is not None:
_args["nomembers"] = nomembers _args["nomembers"] = nomembers
@@ -138,18 +131,15 @@ def gen_args(description, nomembers):
def gen_member_args(hbacsvc): def gen_member_args(hbacsvc):
_args = {} _args = {}
if hbacsvc is not None: if hbacsvc is not None:
_args["member_hbacsvc"] = [to_text(svc) for svc in hbacsvc] _args["member_hbacsvc"] = hbacsvc
return _args return _args
def main(): def main():
ansible_module = AnsibleModule( ansible_module = IPAAnsibleModule(
argument_spec=dict( argument_spec=dict(
# general # general
ipaadmin_principal=dict(type="str", default="admin"),
ipaadmin_password=dict(type="str", required=False, no_log=True),
name=dict(type="list", aliases=["cn"], default=None, name=dict(type="list", aliases=["cn"], default=None,
required=True), required=True),
# present # present
@@ -170,17 +160,15 @@ def main():
# Get parameters # Get parameters
# general # general
ipaadmin_principal = ansible_module.params.get("ipaadmin_principal") names = ansible_module.params_get("name")
ipaadmin_password = ansible_module.params.get("ipaadmin_password")
names = ansible_module.params.get("name")
# present # present
description = ansible_module.params.get("description") description = ansible_module.params_get("description")
nomembers = ansible_module.params.get("nomembers") nomembers = ansible_module.params_get("nomembers")
hbacsvc = ansible_module.params.get("hbacsvc") hbacsvc = ansible_module.params_get("hbacsvc")
action = ansible_module.params.get("action") action = ansible_module.params_get("action")
# state # state
state = ansible_module.params.get("state") state = ansible_module.params_get("state")
# Check parameters # Check parameters
@@ -213,13 +201,9 @@ def main():
changed = False changed = False
exit_args = {} exit_args = {}
ccache_dir = None
ccache_name = None # Connect to IPA API
try: with ansible_module.ipa_connect():
if not valid_creds(ansible_module, ipaadmin_principal):
ccache_dir, ccache_name = temp_kinit(ipaadmin_principal,
ipaadmin_password)
api_connect()
commands = [] commands = []
@@ -257,18 +241,14 @@ def main():
if len(hbacsvc_add) > 0: if len(hbacsvc_add) > 0:
commands.append([name, "hbacsvcgroup_add_member", commands.append([name, "hbacsvcgroup_add_member",
{ {
"hbacsvc": "hbacsvc": hbacsvc_add
[to_text(svc)
for svc in hbacsvc_add],
}]) }])
# Remove members # Remove members
if len(hbacsvc_del) > 0: if len(hbacsvc_del) > 0:
commands.append([name, commands.append([name,
"hbacsvcgroup_remove_member", "hbacsvcgroup_remove_member",
{ {
"hbacsvc": "hbacsvc": hbacsvc_del
[to_text(svc)
for svc in hbacsvc_del],
}]) }])
elif action == "member": elif action == "member":
if res_find is None: if res_find is None:
@@ -278,8 +258,7 @@ def main():
# Ensure members are present # Ensure members are present
commands.append([name, "hbacsvcgroup_add_member", commands.append([name, "hbacsvcgroup_add_member",
{ {
"hbacsvc": [to_text(svc) "hbacsvc": hbacsvc
for svc in hbacsvc],
}]) }])
elif state == "absent": elif state == "absent":
if action == "hbacsvcgroup": if action == "hbacsvcgroup":
@@ -294,8 +273,7 @@ def main():
# Ensure members are absent # Ensure members are absent
commands.append([name, "hbacsvcgroup_remove_member", commands.append([name, "hbacsvcgroup_remove_member",
{ {
"hbacsvc": [to_text(svc) "hbacsvc": hbacsvc
for svc in hbacsvc],
}]) }])
else: else:
ansible_module.fail_json(msg="Unkown state '%s'" % state) ansible_module.fail_json(msg="Unkown state '%s'" % state)
@@ -308,8 +286,7 @@ def main():
errors = [] errors = []
for name, command, args in commands: for name, command, args in commands:
try: try:
result = api_command(ansible_module, command, to_text(name), result = ansible_module.ipa_command(command, name, args)
args)
if "completed" in result: if "completed" in result:
if result["completed"] > 0: if result["completed"] > 0:
changed = True changed = True
@@ -332,12 +309,6 @@ def main():
if len(errors) > 0: if len(errors) > 0:
ansible_module.fail_json(msg=", ".join(errors)) ansible_module.fail_json(msg=", ".join(errors))
except Exception as e:
ansible_module.fail_json(msg=str(e))
finally:
temp_kdestroy(ccache_dir, ccache_name)
# Done # Done
ansible_module.exit_json(changed=changed, **exit_args) ansible_module.exit_json(changed=changed, **exit_args)