internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-31 03:44:41 +00:00
Code Issues Projects Releases Wiki Activity

ipaserver_setup_dns: Properly set ip_addresses, domain and realm

Browse Source 
The parameters ip_addresses, domain and realm have not been properly set
for the setup of dns if _setup_dns as not enabled.
This commit is contained in:
Thomas Woerner
2019-07-17 19:33:23 +02:00
parent b0da219bf5
commit 9d088983d9
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
roles/ipaserver/library/ipaserver_setup_dns.py
View File

@@ -64,6 +64,9 @@ def main():
ansible_module = AnsibleModule( ansible_module = AnsibleModule(
argument_spec = dict( argument_spec = dict(
### basic ### ### basic ###
ip_addresses=dict(required=False, type='list', default=[]),
domain=dict(required=True),
realm=dict(required=True),
hostname=dict(required=True), hostname=dict(required=True),
### server ### ### server ###
setup_dns=dict(required=True, type='bool'), setup_dns=dict(required=True, type='bool'),
@@ -86,6 +89,10 @@ def main():
# set values ############################################################ # set values ############################################################
### basic ### ### basic ###
options.ip_addresses = ansible_module_get_parsed_ip_addresses(
ansible_module)
options.domain_name = ansible_module.params.get('domain')
options.realm_name = ansible_module.params.get('realm')
options.host_name = ansible_module.params.get('hostname') options.host_name = ansible_module.params.get('hostname')
### server ### ### server ###
options.setup_dns = ansible_module.params.get('setup_dns') options.setup_dns = ansible_module.params.get('setup_dns')
@@ -116,8 +123,9 @@ def main():
# Create a BIND instance # Create a BIND instance
bind = bindinstance.BindInstance(fstore) bind = bindinstance.BindInstance(fstore)
bind.set_output(ansible_log) bind.set_output(ansible_log)
bind.setup(host_name, ip_addresses, realm_name, bind.setup(options.host_name, options.ip_addresses,
domain_name, (), 'first', (), options.realm_name,
options.domain_name, (), 'first', (),
zonemgr=options.zonemgr, zonemgr=options.zonemgr,
no_dnssec_validation=options.no_dnssec_validation) no_dnssec_validation=options.no_dnssec_validation)
bind.create_file_with_system_records() bind.create_file_with_system_records()

3
roles/ipaserver/tasks/install.yml
View File

@@ -333,6 +333,9 @@
- name: Install - Setup DNS - name: Install - Setup DNS
ipaserver_setup_dns: ipaserver_setup_dns:
ip_addresses: "{{ ipaserver_ip_addresses | default([]) }}"
domain: "{{ result_ipaserver_test.domain }}"
realm: "{{ result_ipaserver_test.realm }}"
hostname: "{{ result_ipaserver_test.hostname }}" hostname: "{{ result_ipaserver_test.hostname }}"
setup_ca: "{{ result_ipaserver_test.setup_ca }}" setup_ca: "{{ result_ipaserver_test.setup_ca }}"
setup_dns: "{{ ipaserver_setup_dns }}" setup_dns: "{{ ipaserver_setup_dns }}"