internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-31 03:44:41 +00:00
Code Issues Projects Releases Wiki Activity

selfservice: Use IPAAnsibleModule method to validate arguments.

Browse Source 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
This commit is contained in:
Rafael Guterres Jeffman
2021-09-30 21:18:32 -03:00
parent 1ae2c1eb39
commit 970d6c12da
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/modules/ipaselfservice.py
View File

@@ -158,6 +158,7 @@ def main():
state = ansible_module.params_get("state") state = ansible_module.params_get("state")
# Check parameters # Check parameters
invalid = []
if state == "present": if state == "present":
if len(names) != 1: if len(names) != 1:
@@ -165,11 +166,6 @@ def main():
msg="Only one selfservice be added at a time.") msg="Only one selfservice be added at a time.")
if action == "member": if action == "member":
invalid = ["permission"] invalid = ["permission"]
for x in invalid:
if vars()[x] is not None:
ansible_module.fail_json(
msg="Argument '%s' can not be used with action "
"'%s' and state '%s'" % (x, action, state))
if state == "absent": if state == "absent":
if len(names) < 1: if len(names) < 1:
@@ -177,11 +173,8 @@ def main():
invalid = ["permission"] invalid = ["permission"]
if action == "selfservice": if action == "selfservice":
invalid.append("attribute") invalid.append("attribute")
for x in invalid:
if vars()[x] is not None: ansible_module.params_fail_used_invalid(invalid, state, action)
ansible_module.fail_json(
msg="Argument '%s' can not be used with action "
"'%s' and state '%s'" % (x, action, state))
if permission is not None: if permission is not None:
perm = [p for p in permission if p not in ("read", "write")] perm = [p for p in permission if p not in ("read", "write")]