Merge pull request #984 from rjeffman/tests_shell_warn_removal

upstream tests: Removal of 'warn: no' from shell plugins

tests/dnsrecord/test_dnsrecord.yml

@@ -1549,11 +1549,8 @@
   - name: Cleanup test environment.
     include_tasks: env_cleanup.yml
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.  # noqa: deprecated-command-syntax
-    shell:
+    ansible.builtin.shell: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
-      cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.

tests/host/certificate/test_host_certificate.yml

@@ -99,11 +99,9 @@
     register: result
     failed_when: result.changed or result.failed
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.  # noqa: deprecated-command-syntax
     shell:
       cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1, 2, 3]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.

tests/host/certificate/test_hosts_certificate.yml

@@ -98,11 +98,9 @@
     register: result
     failed_when: not result.changed or result.failed
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.  # noqa: deprecated-command-syntax
     shell:
       cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1, 2, 3]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.

tests/service/certificate/test_service_certificate.yml

@@ -214,11 +214,9 @@
       update_dns: yes
       state: absent
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.  # noqa: deprecated-command-syntax
     shell:
       cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1, 2]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.

tests/service/test_service_disable.yml

@@ -100,11 +100,9 @@
   - name: Destroy Kerberos tickets.
     shell: kdestroy -A -q -c ${KRB5CCNAME}
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.  # noqa: deprecated-command-syntax
     shell:
       cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.

tests/user/certificate/test_user_certificate.yml

@@ -80,11 +80,9 @@
     register: result
     failed_when: not result.changed or result.failed
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.  # noqa: deprecated-command-syntax
     shell:
       cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1, 2, 3]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.

tests/user/certificate/test_users_certificate.yml

@@ -93,11 +93,9 @@
     register: result
     failed_when: not result.changed or result.failed
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.  # noqa: deprecated-command-syntax
     shell:
       cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1, 2, 3]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.

tests/user/certmapdata/test_user_certmapdata.yml

@@ -225,11 +225,9 @@
     register: result
     failed_when: not result.changed or result.failed
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.   # noqa: deprecated-command-syntax
     shell:
       cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1, 2, 3]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.

tests/user/certmapdata/test_users_certmapdata.yml

@@ -161,11 +161,9 @@
     register: result
     failed_when: not result.changed or result.failed
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.  # noqa: deprecated-command-syntax
     shell:
       cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1, 2, 3]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.

tests/user/test_users_invalid_cert.yml

@@ -54,11 +54,9 @@
     register: result
     failed_when: not result.changed or result.failed
 
-  - name: Remove certificate files.
+  - name: Remove certificate files.  # noqa: deprecated-command-syntax
     shell:
       cmd: rm -f "private{{ item }}.key" "cert{{ item }}.pem" "cert{{ item }}.der" "cert{{ item }}.b64"
     with_items: [1, 2]
     become: no
     delegate_to: localhost
-    args:
-      warn: no  # suppres warning for not using the `file` module.