From 4c4668b437b9e0f3258e627df9bd693de7243eb5 Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman Date: Thu, 9 Sep 2021 00:17:48 -0300 Subject: [PATCH 1/2] IPAAnsibleModule: Fix example in documentation. In the provided example for the class documentation, the parameters passed to the `ipa_command` method were wrong, as a single list was used instead of a parameter list. --- plugins/module_utils/ansible_freeipa_module.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/module_utils/ansible_freeipa_module.py b/plugins/module_utils/ansible_freeipa_module.py index 45e956d0..cd909c6e 100644 --- a/plugins/module_utils/ansible_freeipa_module.py +++ b/plugins/module_utils/ansible_freeipa_module.py @@ -559,9 +559,9 @@ else: # Execute command if state == "present": - ansible_module.ipa_command(["command_add", name, {}]) + ansible_module.ipa_command("command_add", name, {}) else: - ansible_module.ipa_command(["command_del", name, {}]) + ansible_module.ipa_command("command_del", name, {}) # Done From 602446004afef473ff84fd179fe7414f174e60d2 Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman Date: Thu, 9 Sep 2021 00:19:59 -0300 Subject: [PATCH 2/2] ipatopologysuffix: Fix usage of IPAAnsibleModule. Fix parameters used to IPAAnsibleModule.ipa_command, as a singlo list was being used instead of a parameter list. --- plugins/modules/ipatopologysuffix.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/plugins/modules/ipatopologysuffix.py b/plugins/modules/ipatopologysuffix.py index 47119264..c5be3d3e 100644 --- a/plugins/modules/ipatopologysuffix.py +++ b/plugins/modules/ipatopologysuffix.py @@ -89,8 +89,7 @@ def main(): with ansible_module.ipa_connect(): # Execute command - ansible_module.ipa_command(["topologysuffix_verify", suffix, - {}]) + ansible_module.ipa_command("topologysuffix_verify", suffix, {}) # Done