From 817ac954caf08262bfb2f79f1426b957bd2e8332 Mon Sep 17 00:00:00 2001 From: Thomas Woerner Date: Wed, 22 Jul 2026 15:51:27 +0200 Subject: [PATCH] ipaclient_test: Drop extra ca_cert_files list test ca_cert_files is always a list of strings or None, therefore no isinstance(options.ca_cert_files, list) test needed. Fixes: #1425 (Fix ca_cert_files spec according to implementation) --- roles/ipaclient/library/ipaclient_test.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/roles/ipaclient/library/ipaclient_test.py b/roles/ipaclient/library/ipaclient_test.py index b90ae943..dd99119c 100644 --- a/roles/ipaclient/library/ipaclient_test.py +++ b/roles/ipaclient/library/ipaclient_test.py @@ -460,9 +460,10 @@ def main(): # ClientInstall if options.ca_cert_files is not None: + # ca_cert_files is always a list of strings or None, + # therefore no isinstance(options.ca_cert_files, list) test + # needed. for value in options.ca_cert_files: - if not isinstance(value, list): - raise ValueError("Expected list, got {0!r}".format(value)) # this is what init() does value = value[-1] if not os.path.exists(value):