From 6d04f99cc9857049224e3a74b3a1e1ba9f423696 Mon Sep 17 00:00:00 2001 From: Thomas Woerner Date: Thu, 20 May 2021 13:16:13 +0200 Subject: [PATCH] test_dnszone_name_from_ip.yml: Use result.failed also for failed_when For failed_when result.failed should be used to make sure that the task fails if there was an error. --- tests/dnszone/test_dnszone_name_from_ip.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/dnszone/test_dnszone_name_from_ip.yml b/tests/dnszone/test_dnszone_name_from_ip.yml index fb1086d6..62295742 100644 --- a/tests/dnszone/test_dnszone_name_from_ip.yml +++ b/tests/dnszone/test_dnszone_name_from_ip.yml @@ -38,7 +38,7 @@ name_from_ip: 192.0.2.3/24 default_ttl: 1234 register: result - failed_when: not result.changed + failed_when: not result.changed or result.failed - name: Modify existing zone, using `name_from_ip`, again. ipadnszone: @@ -70,14 +70,14 @@ ipaadmin_password: SomeADMINpassword name_from_ip: fd00::0001 register: result - failed_when: result.changed + failed_when: result.changed or result.failed - name: Ensure second ipv6 zone exists for reverse IPv6. ipadnszone: ipaadmin_password: SomeADMINpassword name_from_ip: 2001:db8:cafe:1::1 register: ipv6_sec_zone - failed_when: not ipv6_sec_zone.changed or ipv6_zone.failed + failed_when: not ipv6_sec_zone.changed or ipv6_zone.failed or ipv6_sec_zone.failed - name: Ensure second ipv6 zone was created. ipadnszone: @@ -91,7 +91,7 @@ ipaadmin_password: SomeADMINpassword name_from_ip: 2001:db8:cafe:1::1 register: result - failed_when: result.changed + failed_when: result.changed or result.failed # Teardown - name: Teardown testing environment