tests/sudorule: Don't become or gather_facts and use only true/false

Unless there's a real need to use privileged access or to gather Ansible
facts upfront, we should always set "become: false" and
"gather_facts: false". In the case that only a few Ansible facts are
required, 'ansible.builtin.setup' with 'gather_subset' should be used.

As the YAML 1.2 standard dictates, boolean values should only use 'true'
or 'false' values.

This patch fixes these issues in the 'sudorule' test suite.
This commit is contained in:
Rafael Guterres Jeffman
2024-11-05 11:08:13 -03:00
parent 4fa0621156
commit 6c94fe9bd5
6 changed files with 38 additions and 20 deletions

View File

@@ -3,11 +3,15 @@
- name: Test sudorule
hosts: "{{ ipa_test_host | default('ipaserver') }}"
become: true
gather_facts: true
gather_facts: false
tasks:
# setup
- name: Ensure DNS Ansible facts are available
ansible.builtin.setup:
gather_subset: dns
- name: Ensure test user is present
ipauser:
ipaadmin_password: SomeADMINpassword
@@ -1157,7 +1161,7 @@
hostmask: 192.168.120.0/24
action: member
register: result
check_mode: yes
check_mode: true
failed_when: not result.changed or result.failed
- name: Ensure sudorule hostmask member is present