internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-05-08 06:13:21 +00:00
Code Issues Projects Releases Wiki Activity

Change 'Exception' to 'RuntimeError' when FreeIPA version is too old

Browse Source 
Changing the use of 'Exception' to 'RuntimeError' has the benefits of
making the error more specific and meaningful for what is being reported
and to remove warnings from linters (pylint).

The same change is applied to all deployment roles.
This commit is contained in:
Rafael Guterres Jeffman
2023-07-12 18:36:48 -03:00
parent d0a8005a7f
commit 63d0272385
3 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
roles/ipaclient/module_utils/ansible_ipa_client.py
View File

@@ -307,8 +307,7 @@ try:
else: else:
# IPA version < 4.4 # IPA version < 4.4
raise RuntimeError("freeipa version '%s' is too old" % VERSION)
raise Exception("freeipa version '%s' is too old" % VERSION)
except ImportError as _err: except ImportError as _err:
ANSIBLE_IPA_CLIENT_MODULE_IMPORT_ERROR = str(_err) ANSIBLE_IPA_CLIENT_MODULE_IMPORT_ERROR = str(_err)

3
roles/ipareplica/module_utils/ansible_ipa_replica.py
View File

@@ -171,8 +171,7 @@ try:
else: else:
# IPA version < 4.6 # IPA version < 4.6
raise RuntimeError("freeipa version '%s' is too old" % VERSION)
raise Exception("freeipa version '%s' is too old" % VERSION)
except ImportError as _err: except ImportError as _err:
ANSIBLE_IPA_REPLICA_MODULE_IMPORT_ERROR = str(_err) ANSIBLE_IPA_REPLICA_MODULE_IMPORT_ERROR = str(_err)

3
roles/ipaserver/module_utils/ansible_ipa_server.py
View File

@@ -212,8 +212,7 @@ try:
else: else:
# IPA version < 4.5 # IPA version < 4.5
raise RuntimeError("freeipa version '%s' is too old" % VERSION)
raise Exception("freeipa version '%s' is too old" % VERSION)
except ImportError as _err: except ImportError as _err:
ANSIBLE_IPA_SERVER_MODULE_IMPORT_ERROR = str(_err) ANSIBLE_IPA_SERVER_MODULE_IMPORT_ERROR = str(_err)