From 873b69107ead9518eed3692adcd165ebb11b6d39 Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman Date: Mon, 1 Feb 2021 17:55:32 -0300 Subject: [PATCH 1/4] example playbooks: Fix invalid variable in ipapermission playbooks. ipapremission playbooks were using the invalid attribute `perm_right`. The attribute was changed to `right`. --- playbooks/permission/permission-allow-read-employeenum.yml | 2 +- playbooks/permission/permission-present.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/playbooks/permission/permission-allow-read-employeenum.yml b/playbooks/permission/permission-allow-read-employeenum.yml index d3021854..98d122fd 100644 --- a/playbooks/permission/permission-allow-read-employeenum.yml +++ b/playbooks/permission/permission-allow-read-employeenum.yml @@ -8,7 +8,7 @@ ipapermission: name: TestPerm2 object_type: user - perm_rights: + right: - read - search - compare diff --git a/playbooks/permission/permission-present.yml b/playbooks/permission/permission-present.yml index 72293ca7..b528401f 100644 --- a/playbooks/permission/permission-present.yml +++ b/playbooks/permission/permission-present.yml @@ -8,4 +8,4 @@ ipapermission: name: TestPerm1 object_type: host - perm_rights: all + right: all From e2c6480fe01d97c2e1e52b86417563dceca7ce6f Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman Date: Mon, 1 Feb 2021 17:58:03 -0300 Subject: [PATCH 2/4] example playbooks: Use default password in ipapermission examples. Example playbooks for ipapermission didn't have default password set. --- playbooks/permission/permission-absent.yml | 1 + playbooks/permission/permission-allow-read-employeenum.yml | 1 + playbooks/permission/permission-member-absent.yml | 1 + playbooks/permission/permission-member-present.yml | 1 + playbooks/permission/permission-present.yml | 1 + playbooks/permission/permission-renamed.yml | 1 + 6 files changed, 6 insertions(+) diff --git a/playbooks/permission/permission-absent.yml b/playbooks/permission/permission-absent.yml index 3ab414e3..982a2c0f 100644 --- a/playbooks/permission/permission-absent.yml +++ b/playbooks/permission/permission-absent.yml @@ -6,6 +6,7 @@ tasks: - name: Ensure permission TestPerm1 is absent ipapermission: + ipaadmin_password: SomeADMINpassword name: TestPerm1 state: absent diff --git a/playbooks/permission/permission-allow-read-employeenum.yml b/playbooks/permission/permission-allow-read-employeenum.yml index 98d122fd..544d87db 100644 --- a/playbooks/permission/permission-allow-read-employeenum.yml +++ b/playbooks/permission/permission-allow-read-employeenum.yml @@ -7,6 +7,7 @@ - name: Ensure permission TestPerm2 is present with Read rights to employeenumber ipapermission: name: TestPerm2 + ipaadmin_password: SomeADMINpassword object_type: user right: - read diff --git a/playbooks/permission/permission-member-absent.yml b/playbooks/permission/permission-member-absent.yml index a3f2eedc..f9ede58a 100644 --- a/playbooks/permission/permission-member-absent.yml +++ b/playbooks/permission/permission-member-absent.yml @@ -6,6 +6,7 @@ tasks: - name: Ensure privilege User Administrators privilege is absent on Permission TestPerm1 ipapermission: + ipaadmin_password: SomeADMINpassword name: TestPerm1 privilege: "User Administrators" action: member diff --git a/playbooks/permission/permission-member-present.yml b/playbooks/permission/permission-member-present.yml index 23ad2783..178ca58f 100644 --- a/playbooks/permission/permission-member-present.yml +++ b/playbooks/permission/permission-member-present.yml @@ -6,6 +6,7 @@ tasks: - name: Ensure permission TestPerm1 is present with the User Administrators privilege present ipapermission: + ipaadmin_password: SomeADMINpassword name: TestPerm1 privilege: "User Administrators" action: member diff --git a/playbooks/permission/permission-present.yml b/playbooks/permission/permission-present.yml index b528401f..5caf3f99 100644 --- a/playbooks/permission/permission-present.yml +++ b/playbooks/permission/permission-present.yml @@ -6,6 +6,7 @@ tasks: - name: Ensure permission TestPerm1 is present ipapermission: + ipaadmin_password: SomeADMINpassword name: TestPerm1 object_type: host right: all diff --git a/playbooks/permission/permission-renamed.yml b/playbooks/permission/permission-renamed.yml index f9753d28..8cc78319 100644 --- a/playbooks/permission/permission-renamed.yml +++ b/playbooks/permission/permission-renamed.yml @@ -6,6 +6,7 @@ tasks: - name: Ensure permission TestPerm1 is present ipapermission: + ipaadmin_password: SomeADMINpassword name: TestPerm1 rename: TestPermRenamed state: renamed From be27a615d03b2eeb1ec00ee7ebc7f1323fdb65ae Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman Date: Mon, 1 Feb 2021 18:01:19 -0300 Subject: [PATCH 3/4] example playbooks: removed permission names from task names. --- playbooks/permission/permission-absent.yml | 3 +-- playbooks/permission/permission-allow-read-employeenum.yml | 2 +- playbooks/permission/permission-member-absent.yml | 2 +- playbooks/permission/permission-member-present.yml | 2 +- playbooks/permission/permission-present.yml | 2 +- playbooks/permission/permission-renamed.yml | 2 +- 6 files changed, 6 insertions(+), 7 deletions(-) diff --git a/playbooks/permission/permission-absent.yml b/playbooks/permission/permission-absent.yml index 982a2c0f..38814df4 100644 --- a/playbooks/permission/permission-absent.yml +++ b/playbooks/permission/permission-absent.yml @@ -4,9 +4,8 @@ become: true tasks: - - name: Ensure permission TestPerm1 is absent + - name: Ensure permission is absent ipapermission: ipaadmin_password: SomeADMINpassword name: TestPerm1 state: absent - diff --git a/playbooks/permission/permission-allow-read-employeenum.yml b/playbooks/permission/permission-allow-read-employeenum.yml index 544d87db..dc8b52df 100644 --- a/playbooks/permission/permission-allow-read-employeenum.yml +++ b/playbooks/permission/permission-allow-read-employeenum.yml @@ -4,7 +4,7 @@ become: true tasks: - - name: Ensure permission TestPerm2 is present with Read rights to employeenumber + - name: Ensure permission is present with set of rights to attribute employeenumber ipapermission: name: TestPerm2 ipaadmin_password: SomeADMINpassword diff --git a/playbooks/permission/permission-member-absent.yml b/playbooks/permission/permission-member-absent.yml index f9ede58a..eb7124c0 100644 --- a/playbooks/permission/permission-member-absent.yml +++ b/playbooks/permission/permission-member-absent.yml @@ -4,7 +4,7 @@ become: true tasks: - - name: Ensure privilege User Administrators privilege is absent on Permission TestPerm1 + - name: Ensure permission privilege, "User Administrators", is absent ipapermission: ipaadmin_password: SomeADMINpassword name: TestPerm1 diff --git a/playbooks/permission/permission-member-present.yml b/playbooks/permission/permission-member-present.yml index 178ca58f..059974c1 100644 --- a/playbooks/permission/permission-member-present.yml +++ b/playbooks/permission/permission-member-present.yml @@ -4,7 +4,7 @@ become: true tasks: - - name: Ensure permission TestPerm1 is present with the User Administrators privilege present + - name: Ensure permission is present with "User Administrators" privilege ipapermission: ipaadmin_password: SomeADMINpassword name: TestPerm1 diff --git a/playbooks/permission/permission-present.yml b/playbooks/permission/permission-present.yml index 5caf3f99..0c353b62 100644 --- a/playbooks/permission/permission-present.yml +++ b/playbooks/permission/permission-present.yml @@ -4,7 +4,7 @@ become: true tasks: - - name: Ensure permission TestPerm1 is present + - name: Ensure permission is present ipapermission: ipaadmin_password: SomeADMINpassword name: TestPerm1 diff --git a/playbooks/permission/permission-renamed.yml b/playbooks/permission/permission-renamed.yml index 8cc78319..8352b7ed 100644 --- a/playbooks/permission/permission-renamed.yml +++ b/playbooks/permission/permission-renamed.yml @@ -4,7 +4,7 @@ become: true tasks: - - name: Ensure permission TestPerm1 is present + - name: Ensure permission TestPerm1 is renamed to TestPermRenamed ipapermission: ipaadmin_password: SomeADMINpassword name: TestPerm1 From 6e45d1ea069f591a2db23aff7d6287136e10ea01 Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman Date: Mon, 1 Feb 2021 18:02:52 -0300 Subject: [PATCH 4/4] example playbooks: use only one permission name. By using only one permission name, examples are easier to follow. --- playbooks/permission/permission-allow-read-employeenum.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/playbooks/permission/permission-allow-read-employeenum.yml b/playbooks/permission/permission-allow-read-employeenum.yml index dc8b52df..951dd735 100644 --- a/playbooks/permission/permission-allow-read-employeenum.yml +++ b/playbooks/permission/permission-allow-read-employeenum.yml @@ -6,8 +6,8 @@ tasks: - name: Ensure permission is present with set of rights to attribute employeenumber ipapermission: - name: TestPerm2 ipaadmin_password: SomeADMINpassword + name: TestPerm1 object_type: user right: - read