internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-28 18:34:44 +00:00
Code Issues Projects Releases Wiki Activity

group: Use IPAAnsibleModule method to validate arguments.

Browse Source 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
This commit is contained in:
Rafael Guterres Jeffman
2021-09-30 21:14:57 -03:00
parent 089400dbd0
commit 602f3a0ff3
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/modules/ipagroup.py
View File

@@ -314,6 +314,7 @@ def main():
state = ansible_module.params_get("state") state = ansible_module.params_get("state")
# Check parameters # Check parameters
invalid = []
if state == "present": if state == "present":
if len(names) != 1: if len(names) != 1:
@@ -322,11 +323,6 @@ def main():
if action == "member": if action == "member":
invalid = ["description", "gid", "posix", "nonposix", "external", invalid = ["description", "gid", "posix", "nonposix", "external",
"nomembers"] "nomembers"]
for x in invalid:
if vars()[x] is not None:
ansible_module.fail_json(
msg="Argument '%s' can not be used with action "
"'%s'" % (x, action))
if state == "absent": if state == "absent":
if len(names) < 1: if len(names) < 1:
@@ -336,11 +332,8 @@ def main():
"nomembers"] "nomembers"]
if action == "group": if action == "group":
invalid.extend(["user", "group", "service", "externalmember"]) invalid.extend(["user", "group", "service", "externalmember"])
for x in invalid:
if vars()[x] is not None: ansible_module.params_fail_used_invalid(invalid, state, action)
ansible_module.fail_json(
msg="Argument '%s' can not be used with state '%s'" %
(x, state))
if external is False: if external is False:
ansible_module.fail_json( ansible_module.fail_json(