internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-30 11:24:50 +00:00
Code Issues Projects Releases Wiki Activity

ipaconfig: Fix fail_json calls.

Browse Source 
Ansible's fail_json() method required that the message paramater was
passed with a keyword parameter, rather than a positional one. Although
this seems to work with ansible-core 2.13+, it might not work with
previous versions of Ansible.

This patch fixes the behaviour for all supported Ansible versions.
This commit is contained in:
Rafael Guterres Jeffman
2022-09-21 10:10:52 -03:00
parent 0ad7635332
commit 4da89de1d4
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/modules/ipaconfig.py
View File

@@ -533,13 +533,14 @@ def main():
required_sid = any([netbios_name, add_sids]) required_sid = any([netbios_name, add_sids])
if required_sid and not enable_sid: if required_sid and not enable_sid:
ansible_module.fail_json( ansible_module.fail_json(
"'enable-sid: yes' required for 'netbios_name' " msg="'enable-sid: yes' required for 'netbios_name' "
"and 'add-sids'." "and 'add-sids'."
) )
if enable_sid: if enable_sid:
if not has_enable_sid: if not has_enable_sid:
ansible_module.fail_json( ansible_module.fail_json(
"This version of IPA does not support 'enable-sid'.") msg="This version of IPA does not support enable-sid."
)
if ( if (
netbios_name netbios_name
and netbios_name == get_netbios_name(ansible_module) and netbios_name == get_netbios_name(ansible_module)