From 12408e0143fa8f91fb42e6d58d3972f5befd4ae7 Mon Sep 17 00:00:00 2001 From: Chris Chapman Date: Thu, 7 Nov 2019 14:05:03 -0700 Subject: [PATCH 1/3] Support 'sn' alias of 'last' for surname --- plugins/modules/ipauser.py | 4 +++- tests/user/test_users.yml | 4 ++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/plugins/modules/ipauser.py b/plugins/modules/ipauser.py index 9d4574f0..1e7ea050 100644 --- a/plugins/modules/ipauser.py +++ b/plugins/modules/ipauser.py @@ -54,6 +54,7 @@ options: last: description: The last name required: false + aliases: ["sn"] fullname: description: The full name required: false @@ -210,6 +211,7 @@ options: last: description: The last name required: false + aliases: ["sn"] fullname: description: The full name required: false @@ -647,7 +649,7 @@ def main(): user_spec = dict( # present first=dict(type="str", aliases=["givenname"], default=None), - last=dict(type="str", default=None), + last=dict(type="str", aliases=["sn"], default=None), fullname=dict(type="str", aliases=["cn"], default=None), displayname=dict(type="str", default=None), initials=dict(type="str", default=None), diff --git a/tests/user/test_users.yml b/tests/user/test_users.yml index 729bb68c..5ef38c87 100644 --- a/tests/user/test_users.yml +++ b/tests/user/test_users.yml @@ -17,7 +17,7 @@ users: - name: user1 givenname: user1 - last: Last + sn: Last - name: user2 first: user2 last: Last @@ -54,7 +54,7 @@ users: - name: user1 givenname: user1 - last: Last + sn: Last - name: user2 first: user2 last: Last From 1e3235e281877f80dfe12bc9bb9f4efb1c0b7218 Mon Sep 17 00:00:00 2001 From: Chris Chapman Date: Sat, 9 Nov 2019 11:44:52 -0700 Subject: [PATCH 2/3] Only change one to test that 'sn' returns the same value as 'last' --- tests/user/test_users.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/user/test_users.yml b/tests/user/test_users.yml index 5ef38c87..129594d3 100644 --- a/tests/user/test_users.yml +++ b/tests/user/test_users.yml @@ -17,7 +17,7 @@ users: - name: user1 givenname: user1 - sn: Last + last: Last - name: user2 first: user2 last: Last From f7eef810afd4397d31d706e87710cf713bfebaba Mon Sep 17 00:00:00 2001 From: Chris Chapman Date: Sat, 9 Nov 2019 11:45:19 -0700 Subject: [PATCH 3/3] Add 'sn' as an alias of 'last' --- README-user.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README-user.md b/README-user.md index e7a934ba..df560086 100644 --- a/README-user.md +++ b/README-user.md @@ -324,7 +324,7 @@ Variable | Description | Required Variable | Description | Required -------- | ----------- | -------- `first` \| `givenname` | The first name string. | no -`last` | The last name | no +`last` \| `sn` | The last name string. | no `fullname` \| `cn` | The full name string. | no `displayname` | The display name string. | no `homedir` | The home directory string. | no