internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-03-26 21:33:05 +00:00
Code Issues Projects Releases Wiki Activity

ansible_freeipa_module: Fix comparison of bool parameters in compare_args_ipa

Browse Source 
Bool types are not iterable. Therefore the comparison using sets was failing
with a TypeError. This prevented to change the bool parameters for hosts.

A test for the host module has been added to verify that the bool parameters
can be modified.

New test:

  tests/host/test_host_bool_params.yml

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1784514
This commit is contained in:
Thomas Woerner
2020-02-11 10:34:39 +01:00
parent 8f69d37e0e
commit 3780a9a00e
2 changed files with 133 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

119
tests/host/test_host_bool_params.yml Normal file
View File

@@ -0,0 +1,119 @@
---
- name: Test host bool parameters
hosts: ipaserver
become: true
tasks:
- name: Get Domain from server name
set_fact:
ipaserver_domain: "{{ groups.ipaserver[0].split('.')[1:] | join ('.') }}"
when: ipaserver_domain is not defined
- name: Set host1_fqdn .. host6_fqdn
set_fact:
host1_fqdn: "{{ 'host1.' + ipaserver_domain }}"
- name: Host absent
ipahost:
ipaadmin_password: MyPassword123
name:
- "{{ host1_fqdn }}"
update_dns: yes
state: absent
- name: Host "{{ host1_fqdn }}" present with requires_pre_auth, ok_as_delegate and ok_to_auth_as_delegate
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
force: yes
requires_pre_auth: yes
ok_as_delegate: yes
ok_to_auth_as_delegate: yes
register: result
failed_when: not result.changed
- name: Host "{{ host1_fqdn }}" present with requires_pre_auth, ok_as_delegate and ok_to_auth_as_delegate again
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
requires_pre_auth: yes
ok_as_delegate: yes
ok_to_auth_as_delegate: yes
register: result
failed_when: result.changed
- name: Host "{{ host1_fqdn }}" present with requires_pre_auth, ok_as_delegate and ok_to_auth_as_delegate set to no
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
requires_pre_auth: no
ok_as_delegate: no
ok_to_auth_as_delegate: no
register: result
failed_when: not result.changed
- name: Host "{{ host1_fqdn }}" present with requires_pre_auth, ok_as_delegate and ok_to_auth_as_delegate set to no again
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
requires_pre_auth: no
ok_as_delegate: no
ok_to_auth_as_delegate: no
register: result
failed_when: result.changed
- name: Host "{{ host1_fqdn }}" present with requires_pre_auth
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
requires_pre_auth: yes
register: result
failed_when: not result.changed
- name: Host "{{ host1_fqdn }}" present with requires_pre_auth again
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
requires_pre_auth: yes
register: result
failed_when: result.changed
- name: Host "{{ host1_fqdn }}" present with ok_as_delegate
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
ok_as_delegate: yes
register: result
failed_when: not result.changed
- name: Host "{{ host1_fqdn }}" present with ok_as_delegate again
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
ok_as_delegate: yes
register: result
failed_when: result.changed
- name: Host "{{ host1_fqdn }}" present with ok_to_auth_as_delegate
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
ok_to_auth_as_delegate: yes
register: result
failed_when: not result.changed
- name: Host "{{ host1_fqdn }}" present with ok_to_auth_as_delegate again
ipahost:
ipaadmin_password: MyPassword123
name: "{{ host1_fqdn }}"
ok_to_auth_as_delegate: yes
register: result
failed_when: result.changed
- name: Host absent
ipahost:
ipaadmin_password: MyPassword123
name:
- "{{ host1_fqdn }}"
update_dns: yes
state: absent