mirror of
https://github.com/freeipa/ansible-freeipa.git
synced 2026-08-01 12:24:43 +00:00
ipaserver_setup_ntp: Fix documentation sections and agument spec
ansible-test with ansible-2.14 is adding a lot of new tests to ensure that the documentation section and the agument spec is complete. Needed changes: DOCUMENTATION section - `type: str` needs to be set for string parameters - `type: list` needs to be set for list parameters - `elements: str` needs to be given for list of string parameters - `required` tags need to be fixed according to the `argument_spec` - `author` needs to be given with the github user also: `Name (@user)` argument_spec - `type='str'` needs to be set for string parameters - `elements='str'` needs to be added to all list of string parameters A call to ansible_ipa_server.check_imports has been added to check for import errors. The `copyright` date is extended with `-2022`.
This commit is contained in:
@@ -5,7 +5,7 @@
|
|||||||
#
|
#
|
||||||
# Based on ipa-client-install code
|
# Based on ipa-client-install code
|
||||||
#
|
#
|
||||||
# Copyright (C) 2017 Red Hat
|
# Copyright (C) 2017-2022 Red Hat
|
||||||
# see file 'COPYING' for use and warranty information
|
# see file 'COPYING' for use and warranty information
|
||||||
#
|
#
|
||||||
# This program is free software; you can redistribute it and/or modify
|
# This program is free software; you can redistribute it and/or modify
|
||||||
@@ -39,12 +39,15 @@ description: Setup NTP
|
|||||||
options:
|
options:
|
||||||
ntp_servers:
|
ntp_servers:
|
||||||
description: ntp servers to use
|
description: ntp servers to use
|
||||||
required: yes
|
type: list
|
||||||
|
elements: str
|
||||||
|
required: no
|
||||||
ntp_pool:
|
ntp_pool:
|
||||||
description: ntp server pool to use
|
description: ntp server pool to use
|
||||||
required: yes
|
type: str
|
||||||
|
required: no
|
||||||
author:
|
author:
|
||||||
- Thomas Woerner
|
- Thomas Woerner (@t-woerner)
|
||||||
'''
|
'''
|
||||||
|
|
||||||
EXAMPLES = '''
|
EXAMPLES = '''
|
||||||
@@ -55,7 +58,7 @@ RETURN = '''
|
|||||||
|
|
||||||
from ansible.module_utils.basic import AnsibleModule
|
from ansible.module_utils.basic import AnsibleModule
|
||||||
from ansible.module_utils.ansible_ipa_server import (
|
from ansible.module_utils.ansible_ipa_server import (
|
||||||
AnsibleModuleLog, setup_logging, options, sysrestore, paths,
|
check_imports, AnsibleModuleLog, setup_logging, options, sysrestore, paths,
|
||||||
redirect_stdout, time_service, sync_time, ntpinstance, timeconf,
|
redirect_stdout, time_service, sync_time, ntpinstance, timeconf,
|
||||||
getargspec
|
getargspec
|
||||||
)
|
)
|
||||||
@@ -64,12 +67,14 @@ from ansible.module_utils.ansible_ipa_server import (
|
|||||||
def main():
|
def main():
|
||||||
ansible_module = AnsibleModule(
|
ansible_module = AnsibleModule(
|
||||||
argument_spec=dict(
|
argument_spec=dict(
|
||||||
ntp_servers=dict(required=False, type='list', default=None),
|
ntp_servers=dict(required=False, type='list', elements='str',
|
||||||
ntp_pool=dict(required=False, default=None),
|
default=None),
|
||||||
|
ntp_pool=dict(required=False, type='str', default=None),
|
||||||
),
|
),
|
||||||
)
|
)
|
||||||
|
|
||||||
ansible_module._ansible_debug = True
|
ansible_module._ansible_debug = True
|
||||||
|
check_imports(ansible_module)
|
||||||
setup_logging()
|
setup_logging()
|
||||||
ansible_log = AnsibleModuleLog(ansible_module)
|
ansible_log = AnsibleModuleLog(ansible_module)
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user