internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-31 03:44:41 +00:00
Code Issues Projects Releases Wiki Activity

DNSZone: Use IPAAnsibleModule.

Browse Source 
As FreeIPABaseModule is deprecated, change DNSZone to use
IPAAnsibleModule.
This commit is contained in:
Rafael Guterres Jeffman
2021-10-26 19:29:24 -03:00
parent f41104520e
commit 2f9791f6c5
1 changed files with 59 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

101
plugins/modules/ipadnszone.py
View File

@@ -200,11 +200,13 @@ dnszone:
from ipapython.dnsutil import DNSName # noqa: E402 from ipapython.dnsutil import DNSName # noqa: E402
from ansible.module_utils.ansible_freeipa_module import ( from ansible.module_utils.ansible_freeipa_module import (
FreeIPABaseModule, IPAAnsibleModule,
is_ip_address, is_ip_address,
is_ip_network_address, is_ip_network_address,
is_valid_port, is_valid_port,
ipalib_errors ipalib_errors,
compare_args_ipa,
IPAParamMapping,
) # noqa: E402 ) # noqa: E402
import netaddr import netaddr
import six import six
@@ -214,31 +216,39 @@ if six.PY3:
unicode = str unicode = str
class DNSZoneModule(FreeIPABaseModule): class DNSZoneModule(IPAAnsibleModule):
ipa_param_mapping = { def __init__(self, *args, **kwargs):
# Direct Mapping # pylint: disable=super-with-arguments
"idnsforwardpolicy": "forward_policy", super(DNSZoneModule, self).__init__(*args, **kwargs)
"idnssoarefresh": "refresh",
"idnssoaretry": "retry", ipa_param_mapping = {
"idnssoaexpire": "expire", # Direct Mapping
"idnssoaminimum": "minimum", "idnsforwardpolicy": "forward_policy",
"dnsttl": "ttl", "idnssoarefresh": "refresh",
"dnsdefaultttl": "default_ttl", "idnssoaretry": "retry",
"idnsallowsyncptr": "allow_sync_ptr", "idnssoaexpire": "expire",
"idnsallowdynupdate": "dynamic_update", "idnssoaminimum": "minimum",
"idnssecinlinesigning": "dnssec", "dnsttl": "ttl",
"idnsupdatepolicy": "update_policy", "dnsdefaultttl": "default_ttl",
# Mapping by method "idnsallowsyncptr": "allow_sync_ptr",
"idnsforwarders": "get_ipa_idnsforwarders", "idnsallowdynupdate": "dynamic_update",
"idnsallowtransfer": "get_ipa_idnsallowtransfer", "idnssecinlinesigning": "dnssec",
"idnsallowquery": "get_ipa_idnsallowquery", "idnsupdatepolicy": "update_policy",
"idnssoamname": "get_ipa_idnssoamname", # Mapping by method
"idnssoarname": "get_ipa_idnssoarname", "idnsforwarders": self.get_ipa_idnsforwarders,
"skip_nameserver_check": "get_ipa_skip_nameserver_check", "idnsallowtransfer": self.get_ipa_idnsallowtransfer,
"skip_overlap_check": "get_ipa_skip_overlap_check", "idnsallowquery": self.get_ipa_idnsallowquery,
"nsec3paramrecord": "get_ipa_nsec3paramrecord", "idnssoamname": self.get_ipa_idnssoamname,
} "idnssoarname": self.get_ipa_idnssoarname,
"skip_nameserver_check": self.get_ipa_skip_nameserver_check,
"skip_overlap_check": self.get_ipa_skip_overlap_check,
"nsec3paramrecord": self.get_ipa_nsec3paramrecord,
}
self.commands = []
self.ipa_params = IPAParamMapping(self, ipa_param_mapping)
self.exit_args = {}
def validate_ips(self, ips, error_msg): def validate_ips(self, ips, error_msg):
invalid_ips = [ invalid_ips = [
@@ -438,39 +448,34 @@ class DNSZoneModule(FreeIPABaseModule):
for zone_name in self.get_zone_names(): for zone_name in self.get_zone_names():
# Look for existing zone in IPA # Look for existing zone in IPA
zone, is_zone_active = self.get_zone(zone_name) zone, is_zone_active = self.get_zone(zone_name)
args = self.get_ipa_command_args(zone=zone) args = self.ipa_params.get_ipa_command_args(zone=zone)
if self.ipa_params.state in ["present", "enabled", "disabled"]: if self.ipa_params.state in ["present", "enabled", "disabled"]:
if not zone: if not zone:
# Since the zone doesn't exist we just create it # Since the zone doesn't exist we just create it
# with given args # with given args
self.add_ipa_command("dnszone_add", zone_name, args) self.commands.append((zone_name, "dnszone_add", args))
is_zone_active = True is_zone_active = True
# just_added = True # just_added = True
else: else:
# Zone already exist so we need to verify if given args # Zone already exist so we need to verify if given args
# matches the current config. If not we updated it. # matches the current config. If not we updated it.
if self.require_ipa_attrs_change(args, zone): if not compare_args_ipa(self, args, zone):
self.add_ipa_command("dnszone_mod", zone_name, args) self.commands.append((zone_name, "dnszone_mod", args))
if self.ipa_params.state == "enabled" and not is_zone_active: if self.ipa_params.state == "enabled" and not is_zone_active:
self.add_ipa_command("dnszone_enable", zone_name) self.commands.append((zone_name, "dnszone_enable", {}))
if self.ipa_params.state == "disabled" and is_zone_active: if self.ipa_params.state == "disabled" and is_zone_active:
self.add_ipa_command("dnszone_disable", zone_name) self.commands.append((zone_name, "dnszone_disable", {}))
if self.ipa_params.state == "absent" and zone is not None: if self.ipa_params.state == "absent" and zone is not None:
self.add_ipa_command("dnszone_del", zone_name) self.commands.append((zone_name, "dnszone_del", {}))
def process_command_result(self, name, command, args, result): def process_results(self, _result, command, name, _args, exit_args):
# pylint: disable=super-with-arguments
super(DNSZoneModule, self).process_command_result(
name, command, args, result
)
if command == "dnszone_add" and self.ipa_params.name_from_ip: if command == "dnszone_add" and self.ipa_params.name_from_ip:
dnszone_exit_args = self.exit_args.setdefault('dnszone', {}) exit_args.setdefault('dnszone', {})["name"] = name
dnszone_exit_args['name'] = name
def get_argument_spec(): def get_argument_spec():
@@ -529,12 +534,24 @@ def get_argument_spec():
def main(): def main():
DNSZoneModule( ansible_module = DNSZoneModule(
argument_spec=get_argument_spec(), argument_spec=get_argument_spec(),
mutually_exclusive=[["name", "name_from_ip"]], mutually_exclusive=[["name", "name_from_ip"]],
required_one_of=[["name", "name_from_ip"]], required_one_of=[["name", "name_from_ip"]],
supports_check_mode=True, supports_check_mode=True,
).ipa_run() )
exit_args = {}
ipaapi_context = ansible_module.params_get("ipaapi_context")
with ansible_module.ipa_connect(context=ipaapi_context):
ansible_module.check_ipa_params()
ansible_module.define_ipa_commands()
changed = ansible_module.execute_ipa_commands(
ansible_module.commands,
result_handler=DNSZoneModule.process_results,
exit_args=exit_args
)
ansible_module.exit_json(changed=changed, **exit_args)
if __name__ == "__main__": if __name__ == "__main__":