From f82b93a801baee8bbaa6acdf879d052c7b03c7fb Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman Date: Fri, 11 Nov 2022 09:41:38 -0300 Subject: [PATCH 1/2] upstream ci: Update Github actions due to old Node.js. There are warnings on Github workflows about the need to update actions 'checkout' and 'setup-python' due to the use of Node.js versions that are too old. This patch updates the use of actions/checkout from v2 to v3.1.0, and setup-python from v2 to v4.3.0. --- .github/workflows/ansible-test.yml | 2 +- .github/workflows/docs.yml | 16 ++++++++-------- .github/workflows/lint.yml | 22 +++++++++++----------- .github/workflows/readme.yml | 2 +- 4 files changed, 21 insertions(+), 21 deletions(-) diff --git a/.github/workflows/ansible-test.yml b/.github/workflows/ansible-test.yml index e1fdf1de..70a8a0ef 100644 --- a/.github/workflows/ansible-test.yml +++ b/.github/workflows/ansible-test.yml @@ -8,7 +8,7 @@ jobs: name: Verify ansible-test sanity runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3.1.0 with: fetch-depth: 0 - name: Install virtualenv using pip diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 27baca9b..ed15b21e 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -8,8 +8,8 @@ jobs: name: Check Ansible Documentation with Ansible 2.9. runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3.1.0 + - uses: actions/setup-python@v4.3.0 with: python-version: '3.x' - name: Install Ansible 2.9 @@ -23,8 +23,8 @@ jobs: name: Check Ansible Documentation with ansible-core 2.11. runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3.1.0 + - uses: actions/setup-python@v4.3.0 with: python-version: '3.x' - name: Install Ansible 2.11 @@ -38,8 +38,8 @@ jobs: name: Check Ansible Documentation with ansible-core 2.12. runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3.1.0 + - uses: actions/setup-python@v4.3.0 with: python-version: '3.x' - name: Install Ansible 2.12 @@ -54,8 +54,8 @@ jobs: name: Check Ansible Documentation with latest Ansible version. runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3.1.0 + - uses: actions/setup-python@v4.3.0 with: python-version: '3.x' - name: Install Ansible-latest diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 5cc1b8a7..ca7b60b5 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -8,8 +8,8 @@ jobs: name: Verify ansible-lint runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3.1.0 + - uses: actions/setup-python@v4.3.0 with: python-version: "3.x" - name: Run ansible-lint @@ -25,8 +25,8 @@ jobs: name: Verify yamllint runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3.1.0 + - uses: actions/setup-python@v4.3.0 with: python-version: "3.x" - name: Run yaml-lint @@ -36,8 +36,8 @@ jobs: name: Verify pydocstyle runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3.1.0 + - uses: actions/setup-python@v4.3.0 with: python-version: "3.x" - name: Run pydocstyle @@ -49,8 +49,8 @@ jobs: name: Verify flake8 runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3.1.0 + - uses: actions/setup-python@v4.3.0 with: python-version: "3.x" - name: Run flake8 @@ -62,8 +62,8 @@ jobs: name: Verify pylint runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 - - uses: actions/setup-python@v2 + - uses: actions/checkout@v3.1.0 + - uses: actions/setup-python@v4.3.0 with: python-version: "3.x" - name: Run pylint @@ -75,6 +75,6 @@ jobs: name: Shellcheck runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3.1.0 - name: Run ShellCheck uses: ludeeus/action-shellcheck@1.1.0 diff --git a/.github/workflows/readme.yml b/.github/workflows/readme.yml index 3933c09c..7c188e68 100644 --- a/.github/workflows/readme.yml +++ b/.github/workflows/readme.yml @@ -8,7 +8,7 @@ jobs: name: Verify readme runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@v3.1.0 - name: Run readme test run: | error=0 From f2632d8c905dc80ad725e845873238cb12a7fee5 Mon Sep 17 00:00:00 2001 From: Rafael Guterres Jeffman Date: Fri, 11 Nov 2022 10:31:05 -0300 Subject: [PATCH 2/2] upstream ci: Use Shellcheck action from 'master'. The Shellcheck action used in Gtihub workflows has bee updated, but has not have a new release in 18 months. It is recommended by the action developers to use the 'master' branch for the action. This patch enables the use of the master branch for the Shellcheck action. --- .github/workflows/lint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index ca7b60b5..1e618932 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -77,4 +77,4 @@ jobs: steps: - uses: actions/checkout@v3.1.0 - name: Run ShellCheck - uses: ludeeus/action-shellcheck@1.1.0 + uses: ludeeus/action-shellcheck@master