internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-31 20:04:45 +00:00
Code Issues Projects Releases Wiki Activity

sudocmdgroup: Use IPAAnsibleModule method to validate arguments.

Browse Source 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
This commit is contained in:
Rafael Guterres Jeffman
2021-09-30 21:19:33 -03:00
parent 7f80a3f140
commit 14c9f308d8
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/modules/ipasudocmdgroup.py
View File

@@ -168,6 +168,7 @@ def main():
state = ansible_module.params_get("state") state = ansible_module.params_get("state")
# Check parameters # Check parameters
invalid = []
if state == "present": if state == "present":
if len(names) != 1: if len(names) != 1:
@@ -175,11 +176,6 @@ def main():
msg="Only one sudocmdgroup can be added at a time.") msg="Only one sudocmdgroup can be added at a time.")
if action == "member": if action == "member":
invalid = ["description", "nomembers"] invalid = ["description", "nomembers"]
for x in invalid:
if vars()[x] is not None:
ansible_module.fail_json(
msg="Argument '%s' can not be used with action "
"'%s'" % (x, action))
if state == "absent": if state == "absent":
if len(names) < 1: if len(names) < 1:
@@ -188,11 +184,8 @@ def main():
invalid = ["description", "nomembers"] invalid = ["description", "nomembers"]
if action == "sudocmdgroup": if action == "sudocmdgroup":
invalid.extend(["sudocmd"]) invalid.extend(["sudocmd"])
for x in invalid:
if vars()[x] is not None: ansible_module.params_fail_used_invalid(invalid, state, action)
ansible_module.fail_json(
msg="Argument '%s' can not be used with state '%s'" %
(x, state))
# Init # Init