internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-07-30 11:24:50 +00:00
Code Issues Projects Releases Wiki Activity

delegation: Use IPAAnsibleModule method to validate arguments.

Browse Source 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
This commit is contained in:
Rafael Guterres Jeffman
2021-09-30 21:12:44 -03:00
parent 23e38fae27
commit 06ccc70c39
1 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/modules/ipadelegation.py
View File

@@ -176,17 +176,14 @@ def main():
# Check parameters # Check parameters
invalid = []
if state == "present": if state == "present":
if len(names) != 1: if len(names) != 1:
ansible_module.fail_json( ansible_module.fail_json(
msg="Only one delegation be added at a time.") msg="Only one delegation be added at a time.")
if action == "member": if action == "member":
invalid = ["permission", "membergroup", "group"] invalid = ["permission", "membergroup", "group"]
for x in invalid:
if vars()[x] is not None:
ansible_module.fail_json(
msg="Argument '%s' can not be used with action "
"'%s' and state '%s'" % (x, action, state))
if state == "absent": if state == "absent":
if len(names) < 1: if len(names) < 1:
@@ -194,11 +191,8 @@ def main():
invalid = ["permission", "membergroup", "group"] invalid = ["permission", "membergroup", "group"]
if action == "delegation": if action == "delegation":
invalid.append("attribute") invalid.append("attribute")
for x in invalid:
if vars()[x] is not None: ansible_module.params_fail_used_invalid(invalid, state, action)
ansible_module.fail_json(
msg="Argument '%s' can not be used with action "
"'%s' and state '%s'" % (x, action, state))
if permission is not None: if permission is not None:
perm = [p for p in permission if p not in ("read", "write")] perm = [p for p in permission if p not in ("read", "write")]