In case endpoint state is absent we shouldn't fail in case service does
not exist, since it means that we're ok, and endpoint is not present.
This might be pretty useful, when user tries to create and delete service
and endpoint with the same code ie [1]
[1] https://opendev.org/openstack/openstack-ansible-tests/src/branch/master/sync/tasks/service_setup.yml
Change-Id: If7ecd7b2e28c81ffe18539731edd4efa599c42ec
Closes-Bug: #1904029
This change merely moves the code to one location. The next logical
step would be to make IronicModule inherit the common ansible module.
Change-Id: Iec0ca1e33de6ebc36d7664941eafe1d77203d8f2
While it's currently possible to set min_ver and max_ver for specific
parameter, there are times when the whole module needs to specify a
minimum version:
- When the object isn't supported at all prior to a version
- When major features are missing from the SDK prior to a version
Change-Id: I94bbff7c54621e8a4786ebc7eb030103255dcb17
The endpoint may be specified in clouds.yaml or via auth, do not
force ironic_url in either of these cases.
Finally, accept "none" as a valid no-auth plugin name.
Change-Id: I4d50b7c55727f022d79df85fb4a163fe3e5fca7b
Refactoring of security_group_rule to depend on the OpenStackModule
class.
See: I487e79fe18c0b9a75df7dacd224ab40ed7f4e1ab
Change-Id: Ide09bdd6a57324a0e1d2ec29c4c49db8dc1c3843
Convert the keypair module to use the OpenStackModule class.
See: I487e79fe18c0b9a75df7dacd224ab40ed7f4e1ab
Change-Id: I60cd5811f1926f53a7f88b19889fba9ca39c6184
We don't use github, so having @ mentions of specific humans is
not valuable. Also, we are a team and own the modules as a team,
so calling out individual authors is philosophically contrary.
We landed a patch upstream to special-case this author string.
Change-Id: I38b4e68f14bbba6e13e8a50e2b202874ab74e3bc
When the module faces API exception we can give much more useful
information to the user. Let us do this for the modules inheriting from
the base class, since all modules should do this at some point in time
Change-Id: I5f1ef01765829900334aa2ecae5dab3ba96f1a49
don't inherit OpenstackModule class from AnsibleModule class to
prevent occasional overriding Ansible methods or vars and failing
module.
Change-Id: Ic34fff0c938eb87cc0d2c5e98fbafed64bf349f6
This is separate from the previous patch - it's just the results
of running the script so we can review the two a little independently.
We should probably squash them.
Change-Id: I838f15cf4a32455a5be20033c8ddc27db6ca15c0
Prior to this change, the os_server_action module could not rebuild
servers, because it passed no arguments to the "rebuild" object.
The imageRef parameter is mandatory. If the client does not specify
imageRef, Nova takes no action to rebuild the server.
Change-Id: I0edbdb634feb90d4c54476a4089fcb014c0b83b2
As per the REST Networking API v2.0 (Subnet) docs, if subnets pools
are not specified, OpenStack networking automatically allocates pools
covering all IP addresses in the CIDR.
In custom vendor specific environments, subnets can be created without
allocation pools via UI due to which subnets will not have any existing
allocation pools. Under this scenario, module throws an
"IndexError: list index out of range" error.
Also, allow to add more allocation pools on top of existing allocation
pools.
Change-Id: Ib8becf5e958f1bc8e5c9fd76f1722536bf1c9f1a
Keystone supports setting custom properties for projects. This changes add
properties to os_project to enable setting of custom properties.
Depends-On: https://review.opendev.org/715255
Change-Id: I23e2834d6b9d40ce86db4b32a0ed8bf76b3d9879
