9 Commits

Author	SHA1	Message	Date
Jakob Meng	9f3f0837c8	Updated network module docs ... The network module does support updates since Will's patch [1]. [1] https://review.opendev.org/c/openstack/ansible-collections-openstack/+/854170 Story: 2010024 Task: 45262 Change-Id: I9e4af2c6e685686e28e7f2ae56a615529a6d7b59	2022-09-21 20:09:01 +00:00
Will Szumski	2d0656f072	Allow networks to be updated ... Neutron will allow you to update certain properties of the network after creation. This change modifies the ansible code to perform an update call if it detects that any updatable properties have been changed. If you attempt to change a property that cannot be updated, the module will fail. This gives you confidence that the ansible configuration matches the state of the network in OpenStack. If we did not fail in this way, you might think you have updated the network, but in reality those changes would be silently ignored. Prior to this change, the only way to update properties of a network was to delete it and then recreate. Story: 2010024 Task: 45262 Change-Id: I4af2b50f207f349b58c63e0a4e92816ada0847fd	2022-09-20 10:02:41 +00:00
Jakob Meng	0b2b56765c	Fixed Python shebang and UTF-8 coding in modules ... Be consistent with Ansible docs [1], [2], [3]. [1] https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html [2] https://docs.ansible.com/ansible-core/devel/dev_guide/testing/sanity/shebang.html [3] b86a18bd27/test/lib/ansible_test/_util/controller/sanity/code-smell/shebang.py Change-Id: Ia3976bb3fcca662cefa219edeef057bcb7143c01	2022-07-28 10:03:09 +02:00
Jakob Meng	0215e2a5d4	Dropped default module options ... Removed default=None, type='str' and required=False from all module's argument_specs with sed -i \ -e 's/default=None, //g' \ -e 's/default=None,//g' \ -e 's/default=None//g' \ -e "s/type='str', //g" \ -e "s/type='str',//g" \ -e "s/type='str'//g" \ -e 's/required=False, //g' \ -e 's/required=False,//g' \ -e 's/required=False//g' \ plugins/modules/*.py plugins/module_utils/*.py and manually cleaned the results because those options values are the default in Ansible. Ref.: https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#argument-spec Change-Id: Icbc3bb84269d3b8205fac259300902ebdaf6a3ae	2022-07-27 12:39:44 +02:00
Sagi Shnaidman	9272146cf7	Change network modules to work with new SDK ... Change-Id: I7625d696f6462a7a955008a5c7276f1548acbc2e	2022-06-02 15:33:38 +02:00
frenzy_friday	0ac75add62	Migrating network from AnsibleModule to OpenStackModule ... 1. Created class NetworkModule with run method 2. Changed argument_spec from openstack_full_argument_spec to dict 3. Removed checking min_version for individual parameters and instead used check_versioned method for all together. 4. Since create_network method uses "mtu_size" as a parameter and not "mtu", changed the key "mtu" to "mtu_size" in argument spec and added alias as "mtu" to still support mtu keyword in playbook. 5. Changed "mtu" to "mtu_size" to match in the doc Change-Id: Ic4ddedb43044434df0a18f8aacacd21149e6f0b0	2020-12-15 15:39:22 +01:00
Monty Taylor	a96d28dfbc	Update author lines ... We don't use github, so having @ mentions of specific humans is not valuable. Also, we are a team and own the modules as a team, so calling out individual authors is philosophically contrary. We landed a patch upstream to special-case this author string. Change-Id: I38b4e68f14bbba6e13e8a50e2b202874ab74e3bc	2020-06-23 21:50:43 +03:00
Sagi Shnaidman	572fe85894	Remove ANSIBLE_METADATA from all modules ... It's not required for collections, for more details: https://github.com/ansible-collections/overview/issues/57 Change-Id: I954eef25bb9837c9282665ad5586dbe37f4f4424	2020-05-14 17:00:01 +03:00
Monty Taylor	e47c4671c7	Rename all of the modules ... This is separate from the previous patch - it's just the results of running the script so we can review the two a little independently. We should probably squash them. Change-Id: I838f15cf4a32455a5be20033c8ddc27db6ca15c0	2020-05-12 10:20:50 -05:00