9 Commits

Author	SHA1	Message	Date
Sagi Shnaidman	a180f339a8	Fix documentation defaults for modules ... Match defaults in spec and documentation, make happy ansible-test. Change-Id: Ifd6a02e957d1f0df27d89c350fb9d1ebf1ca7680 Signed-off-by: Sagi Shnaidman <sshnaidm@redhat.com>	2022-11-02 21:19:02 +00:00
Jakob Meng	41299b9666	Refactored stack module and use stack's tag(s) attribute ... Dropped stack status checks for CREATE_COMPLETE and UPDATE_\ COMPLETE and instead pass wait=True to openstacksdk's create_stack() and update_stack() calls because those will call event_utils.\ poll_for_events() which garantees that stack has reached those states when they return [1],[2]. Check for duplicate keys in parameters which already have been defined by regular module attributes. Raise an error to warn users that they tried to overwrite parameters which they already specified with module attributes. Renamed stack's module attribute 'tag' to 'tags' to match both openstacksdk and OpenStack API and clarify that more than a single tag can be specified. Added 'tag' as an alias to keep backward compatibility. Actually pass the 'tags' aka 'tag' attribute to stack create and update functions of the openstacksdk which was lost in [3]. Added tags to integration tests. Sorted argument specs and documentation of the stack module and marked attributes which are not updatable. Dropped condition from self.conn.delete_stack() because the latter will only return False when a stack could not be found which we already. self.conn.delete_stack() will raise an exception when stack deletion fails. Renamed ci integration tests from 'orchestration' to 'stack' in order to match module name and adapted tags accordingly. Fixed and enabled ci integration tests for stack and stack_info modules. Dropped 'stack_name' from module return values in RETURN docstring and ci integration tests because openstacksdk not return this attribute. [1] 9b1c433352/openstack/cloud/_orchestration.py (L92) [2] 9b1c433352/openstack/cloud/_orchestration.py (L148) [3] af79857bfb Change-Id: I4ace6012112bbcce9094353e27eb4066cf25f229	2022-10-07 19:08:28 +00:00
anbanerj	41f3007a80	Makes stack module compatible with new sdk version ... Change-Id: Iec99be0f422f1fab9b17e581b7b47a7540de749c	2022-09-27 10:28:56 +02:00
Jakob Meng	0b2b56765c	Fixed Python shebang and UTF-8 coding in modules ... Be consistent with Ansible docs [1], [2], [3]. [1] https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html [2] https://docs.ansible.com/ansible-core/devel/dev_guide/testing/sanity/shebang.html [3] b86a18bd27/test/lib/ansible_test/_util/controller/sanity/code-smell/shebang.py Change-Id: Ia3976bb3fcca662cefa219edeef057bcb7143c01	2022-07-28 10:03:09 +02:00
Jakob Meng	0215e2a5d4	Dropped default module options ... Removed default=None, type='str' and required=False from all module's argument_specs with sed -i \ -e 's/default=None, //g' \ -e 's/default=None,//g' \ -e 's/default=None//g' \ -e "s/type='str', //g" \ -e "s/type='str',//g" \ -e "s/type='str'//g" \ -e 's/required=False, //g' \ -e 's/required=False,//g' \ -e 's/required=False//g' \ plugins/modules/*.py plugins/module_utils/*.py and manually cleaned the results because those options values are the default in Ansible. Ref.: https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#argument-spec Change-Id: Icbc3bb84269d3b8205fac259300902ebdaf6a3ae	2022-07-27 12:39:44 +02:00
Artem Goncharov	af79857bfb	Switch Stack module to OpenStackModule ... Switch stack module to the general OpenStackModule. Change-Id: I98006adcb16c57d5d00990ef6cb76298ff9af9f9	2021-05-25 10:37:19 +02:00
Monty Taylor	a96d28dfbc	Update author lines ... We don't use github, so having @ mentions of specific humans is not valuable. Also, we are a team and own the modules as a team, so calling out individual authors is philosophically contrary. We landed a patch upstream to special-case this author string. Change-Id: I38b4e68f14bbba6e13e8a50e2b202874ab74e3bc	2020-06-23 21:50:43 +03:00
Sagi Shnaidman	572fe85894	Remove ANSIBLE_METADATA from all modules ... It's not required for collections, for more details: https://github.com/ansible-collections/overview/issues/57 Change-Id: I954eef25bb9837c9282665ad5586dbe37f4f4424	2020-05-14 17:00:01 +03:00
Monty Taylor	e47c4671c7	Rename all of the modules ... This is separate from the previous patch - it's just the results of running the script so we can review the two a little independently. We should probably squash them. Change-Id: I838f15cf4a32455a5be20033c8ddc27db6ca15c0	2020-05-12 10:20:50 -05:00