6 Commits

Author	SHA1	Message	Date
Jakob Meng	34b0abb4ca	Refactored floating_ip and floating_ip_info modules ... Use service proxies from openstacksdk wherever reasonable in order to reduce calls to OpenStack API. Renamed floating_ip_info's attribute 'project_id' to 'project' to be consistent with other attributes and added the former as an alias to keep backward compatibility. The latter can now also be used to search for floating ips by project names, not only project ids. Sorted argument specs and documentation of both modules. Reworked integration tests, e.g. replaced references to server's 'addresses' attribute with calls to our port_info and floating_ip_info modules. Also reformatted tests and added assertion on return values. Merged integration tests of floating_ip_info module into floating_ip module, because the former does not create any floating ips and assumes that they have been created earlier. For Zuul CI job ansible-collections-openstack-functional-devstack-\ releases to pass, the minimum required openstacksdk release must be 0.102.0 because [1],[2],[3],[4] are available since that release only. [1] https://review.opendev.org/c/openstack/openstacksdk/+/851976 [2] 0ded7ac398 [3] https://review.opendev.org/c/openstack/openstacksdk/+/859672 [4] 2535ba7a28 Change-Id: I129f866e7ed8d5c0499c93e78ebbe2c424e09423	2022-10-14 12:09:28 +02:00
Jakob Meng	0b2b56765c	Fixed Python shebang and UTF-8 coding in modules ... Be consistent with Ansible docs [1], [2], [3]. [1] https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html [2] https://docs.ansible.com/ansible-core/devel/dev_guide/testing/sanity/shebang.html [3] b86a18bd27/test/lib/ansible_test/_util/controller/sanity/code-smell/shebang.py Change-Id: Ia3976bb3fcca662cefa219edeef057bcb7143c01	2022-07-28 10:03:09 +02:00
Jakob Meng	0215e2a5d4	Dropped default module options ... Removed default=None, type='str' and required=False from all module's argument_specs with sed -i \ -e 's/default=None, //g' \ -e 's/default=None,//g' \ -e 's/default=None//g' \ -e "s/type='str', //g" \ -e "s/type='str',//g" \ -e "s/type='str'//g" \ -e 's/required=False, //g' \ -e 's/required=False,//g' \ -e 's/required=False//g' \ plugins/modules/*.py plugins/module_utils/*.py and manually cleaned the results because those options values are the default in Ansible. Ref.: https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#argument-spec Change-Id: Icbc3bb84269d3b8205fac259300902ebdaf6a3ae	2022-07-27 12:39:44 +02:00
Jakob Meng	41ad425d23	Dropped deprecated return values in floating_ip_info and assert remaining fields ... Attributes such as location and tenant_id are computed by OpenStack SDK. We do not return these fields in floating_ip_info because e.g. tenant_id has been marked as deprecated and is a copy of the project_id field. Ref.: 70a06d9990 Added an assertion to CI which checks that all advertised fields are returned by floating_ip_info. This helps with detecting breaking changes in future updates. Change-Id: I62e4681cd57f82054f68efe1dc59be2cca118135	2022-04-06 07:58:41 +00:00
Sagi Shnaidman	2d554d1e22	Add support check mode for all info modules ... As it's required by new ansible-test rules. See https://github.com/ansible-collections/overview/issues/45#issuecomment-893543025 Change-Id: Ib6b73e810b972997b8de2b4a9eb8e07e246823d5	2021-08-16 15:56:27 +03:00
Polina Gubina	17d5c7de8e	Floating ip info module ... Change-Id: If932651c9d7a1819f805a49b020826682c5b8087	2021-05-27 12:03:04 +03:00