Commit Graph
8 Commits
Author SHA1 Message Date
Jesse Pretorius (odyssey4me) 0f196864b3 Bump min openstacksdk version for os_network/{port_security_enabled,mtu}
To make use of the port_security_enabled [a] and mtu [b] parameters,
[c] and [d] need to be present in the openstacksdk or the os_network
module with return an error like:

TypeError: create_network() got an unexpected keyword argument 'port_security_enabled'

or:

TypeError: create_network() got an unexpected keyword argument 'mtu'

To handle this, we fail the module if one of the arguments are used
and the minimum openstacksdk version for that argument is not met.

[a] https://github.com/ansible/ansible/commit/eaf238b033a0504c48440cf85982a2b89851059d
[b] https://github.com/ansible/ansible/commit/c6a8e99d34eeacd84b097bb0bd2ba9a0d7fb230d
[c] https://github.com/openstack/openstacksdk/commit/8eb788af07ed88166db7b8a58ce1fecacd7a29b1
[d] https://github.com/openstack/openstacksdk/commit/a1fc820a2f3669f64d222506c17be99c4d6be7b7

Fixes: https://github.com/ansible/ansible/issues/62062
Change-Id: I2b80dc721a08bbdb530af3705ae99cf1b579d9f0
2020-02-18 12:46:00 +00:00
Abhijeet Kasurde b455295f92 Update root hint documentation link
Root hint documentation link points to non-existing link.
This patch corrects this link.

Fixes: https://github.com/ansible/ansible/issues/67357

Change-Id: I1ad77ca2b1007ed1660ac938c6fee7f4059a979c
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-13 14:29:30 +05:30
Jesse Pretorius (odyssey4me) 1a597c2b03 Bump minimum openstacksdk version when using os_network/dns_domain
With the addition of [a], the minimum openstacksdk version needs to
be bumped to include [b], or the os_network module will return the
error:

TypeError: create_network() got an unexpected keyword argument 'dns_domain'

To handle this, we fail the module if the dns_domain argument is used
and the minimum openstacksdk version for that argument is not met.

[a] https://github.com/ansible/ansible/commit/6c74e29618a6872bc0da66e4992cfcd9cebf6acc
[b] https://github.com/openstack/openstacksdk/commit/a3e846e2b9301f4ae725e97b21b4313bfcc81d10

Fixes: #64495
Fixes: #64841
Change-Id: I8c41e505d5c1949ddc535c78933da06405c47299
2020-01-30 17:40:03 +00:00
ZuulandGerrit Code Review d36da2d1ce Merge "Fix argument spec for os_subnet and os_zone" 2020-01-28 01:22:42 +00:00
Bram Verschueren c7506b5b10 fix os_user_role for groups in multidomain context
This fixes searching for a group in multi-domain context by passing the
domain_id in the call to get_groups.

original github PR: https://github.com/ansible/ansible/pull/62858

Change-Id: Ia2216728c15cc9d9a5e29bfe6b9fc63d2c6982ce
Task: 38375
Story: 2007209
2020-01-23 08:22:46 +01:00
Abhijeet KasurdeandSagi Shnaidman ead550d34e Fix argument spec for os_subnet and os_zone
Ansible argument spec provides facility to provide choices
for the given parameter.
Module os_subnet and os_zone spells 'choices' incorrectly.
This change fixes these modules, by changing 'choice' to 'choices'.

Original Upstream PR: https://github.com/ansible/ansible/pull/65497

Change-Id: I3eed5feeef1234996f22bf8dfe7ecec0bc8eb298
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-01-22 13:19:00 +02:00
Valery TschoppandSagi Shnaidman 4c03ae0c16 Fix os_user_role issue to grant a role in a domain
Set domain_id when domain is set or project/domain is set.

Change-Id: I0f189647cd9b97252f29055506f75dfd8398dee4
Task: 38309
Story: 2007184
2020-01-21 16:56:16 +00:00
Sagi Shnaidman 6ac08e7f0e Migrate openstack modules as a collection
Migrate accordin to Ansible guidelines [1[]] and tool
migrate.py [2]
Also fixed ALL ansible-test sanity issues

Add pep8 and linter job with runs ansible-test sanity test.

[1] https://etherpad.openstack.org/p/openstack-ansible-modules
[2] https://github.com/ansible-community/collection_migration

Change-Id: Ib2b1c8f23aacfca95304132bfe5c4cdedbea0520
2020-01-17 14:07:24 +00:00