7 Commits

Author	SHA1	Message	Date
Jakob Meng	1b38b7c500	Properly documented openstacksdk version requirements ... With "extends_documentation_fragment: ['openstack.cloud.openstack']" it is not necessary to list required Python libraries in section 'requirements' of DOCUMENTATION docstring in modules. Ansible will merge requirements from doc fragments and DOCUMENTATION docstring which previously resulted in duplicates such as in server module [0]: * openstacksdk * openstacksdk >= 0.36, < 0.99.0 * python >= 3.6 When removing the 'requirements' section from server module, then Ansible will list openstacksdk once only: * openstacksdk >= 0.36, < 0.99.0 * python >= 3.6 To see what documentation Ansible will produce for server module run: ansible-doc --type module openstack.cloud.server [0] https://docs.ansible.com/ansible/latest/collections/openstack/\ cloud/server_module.html Change-Id: I727ed95ee480bb644b5a533f6a9526973677064c	2023-01-16 13:51:01 +01:00
Jakob Meng	4cf6842222	Refactored security_group{,_info} modules ... Change-Id: I8ae38c038e24ae53704224adb614b98e2e56a271	2023-01-11 07:36:59 +01:00
Jakob Meng	0b2b56765c	Fixed Python shebang and UTF-8 coding in modules ... Be consistent with Ansible docs [1], [2], [3]. [1] https://docs.ansible.com/ansible/latest/dev_guide/developing_modules_documenting.html [2] https://docs.ansible.com/ansible-core/devel/dev_guide/testing/sanity/shebang.html [3] b86a18bd27/test/lib/ansible_test/_util/controller/sanity/code-smell/shebang.py Change-Id: Ia3976bb3fcca662cefa219edeef057bcb7143c01	2022-07-28 10:03:09 +02:00
Jakob Meng	0215e2a5d4	Dropped default module options ... Removed default=None, type='str' and required=False from all module's argument_specs with sed -i \ -e 's/default=None, //g' \ -e 's/default=None,//g' \ -e 's/default=None//g' \ -e "s/type='str', //g" \ -e "s/type='str',//g" \ -e "s/type='str'//g" \ -e 's/required=False, //g' \ -e 's/required=False,//g' \ -e 's/required=False//g' \ plugins/modules/*.py plugins/module_utils/*.py and manually cleaned the results because those options values are the default in Ansible. Ref.: https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#argument-spec Change-Id: Icbc3bb84269d3b8205fac259300902ebdaf6a3ae	2022-07-27 12:39:44 +02:00
anbanerj	d600284645	Makes security_group_info compatible with new openstacksdk ... Updated documentation of return values and added test to verify return values Function self.conn.search_security_groups() cannot be used here. Arguments for filtering such as 'description' would have to be passed to self.conn.search_security_groups() in its 'filters' argument [1]. The latter is passed to both as query arguments to OpenStack API and later to _utils._filter_list() [2] for filtering the results. Some arguments such as 'any_tags' are only used as query arguments by openstacksdk [3] when querying OpenStack API. They are no valid attributes in security_group.py [4]. Whenever those non-attribute arguments are passed to self.conn.search_security_groups(), _utils._filter_list() [2] would drop all results because no result would have a matching attributes. [1] 0898398415/openstack/cloud/_security_group.py (L31) [2] 0898398415/openstack/cloud/_utils.py (L63) [3] 0898398415/openstack/common/tag.py (L19) [4] 0898398415/openstack/network/v2/security_group.py Change-Id: Ie7fe9d2e973d38751c48e71e6bd55e56a591ac1f	2022-07-05 15:52:48 +02:00
Sagi Shnaidman	2d554d1e22	Add support check mode for all info modules ... As it's required by new ansible-test rules. See https://github.com/ansible-collections/overview/issues/45#issuecomment-893543025 Change-Id: Ib6b73e810b972997b8de2b4a9eb8e07e246823d5	2021-08-16 15:56:27 +03:00
Artem Goncharov	e4c7bd3df8	Add security_group_info module ... Let's add a new missing module for getting info about security groups. Add tests. Change-Id: Ib032c8d14444cea1fcbfd98d252cc56b9f5f383e	2021-02-04 02:22:31 +02:00