From 8aefe5dc3a0fc5c62fbfbaf990d3d84f68d45954 Mon Sep 17 00:00:00 2001 From: Clark Boylan Date: Thu, 3 Oct 2024 11:18:11 -0700 Subject: [PATCH] Run functional testing regardless of pep8/linter results The parent change was pushed up initially with a super minor pep8 under indentation issue. The Zuul config at the time prevent functional testing from running so we got no indiciation of whether or not the proposed fix actually fixed the issue. Update the Zuul config to run pep8 and functional tests concurrently. Formatting errors are independent of functionality and getting quick feedback on both gives contributors and reviewers as much feedback as possible when making decisions about the next step for the code review process. The fewer round trips we force everyone to make the less likely we are to forget about a change or ignore it and otherwise extend the time it takes to get code merged. Change-Id: Ib92b3b80f2873327161e23b0ce6bfc6c34850538 --- .zuul.yaml | 26 +++++++------------------- 1 file changed, 7 insertions(+), 19 deletions(-) diff --git a/.zuul.yaml b/.zuul.yaml index 999b1c5c..fa8565ba 100644 --- a/.zuul.yaml +++ b/.zuul.yaml @@ -284,31 +284,19 @@ - tox-pep8 - openstack-tox-linters-ansible-devel - openstack-tox-linters-ansible-2.12 - - ansible-collections-openstack-functional-devstack: - dependencies: &deps_unit_lint - - tox-pep8 - - openstack-tox-linters-ansible-2.12 - - - ansible-collections-openstack-functional-devstack-releases: - dependencies: *deps_unit_lint - - ansible-collections-openstack-functional-devstack-ansible-2.9: - dependencies: *deps_unit_lint - - ansible-collections-openstack-functional-devstack-ansible-2.12: - dependencies: *deps_unit_lint - - ansible-collections-openstack-functional-devstack-ansible-devel: - dependencies: *deps_unit_lint - - ansible-collections-openstack-functional-devstack-magnum: - dependencies: *deps_unit_lint - - ansible-collections-openstack-functional-devstack-octavia: - dependencies: *deps_unit_lint + - ansible-collections-openstack-functional-devstack + - ansible-collections-openstack-functional-devstack-releases + - ansible-collections-openstack-functional-devstack-ansible-2.9 + - ansible-collections-openstack-functional-devstack-ansible-2.12 + - ansible-collections-openstack-functional-devstack-ansible-devel + - ansible-collections-openstack-functional-devstack-magnum + - ansible-collections-openstack-functional-devstack-octavia - bifrost-collections-src: voting: false - dependencies: *deps_unit_lint irrelevant-files: *ignore_files - bifrost-keystone-collections-src: voting: false - dependencies: *deps_unit_lint irrelevant-files: *ignore_files gate: