From 15f7f7fc7bcb090c52ebaeb0f2fef110434c2621 Mon Sep 17 00:00:00 2001 From: Monty Taylor Date: Mon, 9 Dec 2019 13:19:58 -0500 Subject: [PATCH] Fix F841 and remove exclusion Change-Id: I92802ced580d42781cfd875389daa232aa8a64a5 --- plugins/modules/os_project_access.py | 1 - plugins/modules/os_router.py | 1 - tox.ini | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/plugins/modules/os_project_access.py b/plugins/modules/os_project_access.py index ecc4a61d..fbb79e73 100644 --- a/plugins/modules/os_project_access.py +++ b/plugins/modules/os_project_access.py @@ -121,7 +121,6 @@ def main(): sdk, cloud = openstack_cloud_from_module(module) - changed = False state = module.params['state'] resource_name = module.params['resource_name'] resource_type = module.params['resource_type'] diff --git a/plugins/modules/os_router.py b/plugins/modules/os_router.py index c2ed9261..8b8f4255 100644 --- a/plugins/modules/os_router.py +++ b/plugins/modules/os_router.py @@ -329,7 +329,6 @@ def _validate_subnets(module, cloud, filters=None): internal_subnet_ids = [] internal_port_ids = [] existing_port_ips = [] - existing_port_ids = [] if module.params['external_fixed_ips']: for iface in module.params['external_fixed_ips']: subnet = cloud.get_subnet(iface['subnet']) diff --git a/tox.ini b/tox.ini index 7ac4dd99..685d0b56 100644 --- a/tox.ini +++ b/tox.ini @@ -51,7 +51,7 @@ commands = {posargs} # H4 are rules for docstrings. Maybe we should clean them? # E501,E402,H301,H236,F401,E128 are ignored so we can import the existing # modules unchanged and then clean them in subsequent patches. -ignore = W503,H4,E501,E402,H301,H236,F401,E128,W504,F841,F403,F405 +ignore = W503,H4,E501,E402,H301,H236,F401,E128,W504,F403,F405 show-source = True exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,ansible_collections