Switch ServerMetadata module to OpenStackModule

Switch ServerMetadata module to the general OpenStackModule.

Change-Id: If3f3086a964c47407ec82dda662d2c1524283fb6
This commit is contained in:
Artem Goncharov
2021-05-20 14:08:13 +02:00
parent 6b3bf3bba0
commit 2a461cadd9

View File

@@ -93,77 +93,72 @@ metadata:
sample: {'key1': 'value1', 'key2': 'value2'} sample: {'key1': 'value1', 'key2': 'value2'}
''' '''
from ansible.module_utils.basic import AnsibleModule from ansible_collections.openstack.cloud.plugins.module_utils.openstack import OpenStackModule
from ansible_collections.openstack.cloud.plugins.module_utils.openstack import (
openstack_full_argument_spec,
openstack_module_kwargs,
openstack_cloud_from_module,
)
def _needs_update(server_metadata=None, metadata=None): class ServerMetadataModule(OpenStackModule):
if server_metadata is None: argument_spec = dict(
server_metadata = {}
if metadata is None:
metadata = {}
return len(set(metadata.items()) - set(server_metadata.items())) != 0
def _get_keys_to_delete(server_metadata_keys=None, metadata_keys=None):
if server_metadata_keys is None:
server_metadata_keys = []
if metadata_keys is None:
metadata_keys = []
return set(server_metadata_keys) & set(metadata_keys)
def main():
argument_spec = openstack_full_argument_spec(
server=dict(required=True, aliases=['name']), server=dict(required=True, aliases=['name']),
meta=dict(required=True, type='dict'), meta=dict(required=True, type='dict'),
state=dict(default='present', choices=['absent', 'present']), state=dict(default='present', choices=['absent', 'present']),
) )
module_kwargs = openstack_module_kwargs() module_kwargs = dict(
module = AnsibleModule(argument_spec, supports_check_mode=True
supports_check_mode=True, )
**module_kwargs)
state = module.params['state'] def _needs_update(self, server_metadata=None, metadata=None):
server_param = module.params['server'] if server_metadata is None:
meta_param = module.params['meta'] server_metadata = {}
changed = False if metadata is None:
metadata = {}
return len(set(metadata.items()) - set(server_metadata.items())) != 0
sdk, cloud = openstack_cloud_from_module(module) def _get_keys_to_delete(self, server_metadata_keys=None, metadata_keys=None):
try: if server_metadata_keys is None:
server = cloud.get_server(server_param) server_metadata_keys = []
if metadata_keys is None:
metadata_keys = []
return set(server_metadata_keys) & set(metadata_keys)
def run(self):
state = self.params['state']
server_param = self.params['server']
meta_param = self.params['meta']
changed = False
server = self.conn.get_server(server_param)
if not server: if not server:
module.fail_json( self.fail_json(
msg='Could not find server {0}'.format(server_param)) msg='Could not find server {0}'.format(server_param))
if state == 'present': if state == 'present':
# check if it needs update # check if it needs update
if _needs_update(server_metadata=server.metadata, if self._needs_update(
metadata=meta_param): server_metadata=server.metadata, metadata=meta_param
if not module.check_mode: ):
cloud.set_server_metadata(server_param, meta_param) if not self.ansible.check_mode:
self.conn.set_server_metadata(server_param, meta_param)
changed = True changed = True
elif state == 'absent': elif state == 'absent':
# remove from params the keys that do not exist in the server # remove from params the keys that do not exist in the server
keys_to_delete = _get_keys_to_delete(server.metadata.keys(), keys_to_delete = self._get_keys_to_delete(
meta_param.keys()) server.metadata.keys(), meta_param.keys())
if len(keys_to_delete) > 0: if len(keys_to_delete) > 0:
if not module.check_mode: if not self.ansible.check_mode:
cloud.delete_server_metadata(server_param, keys_to_delete) self.conn.delete_server_metadata(
server_param, keys_to_delete)
changed = True changed = True
if changed: if changed:
server = cloud.get_server(server_param) server = self.conn.get_server(server_param)
module.exit_json( self.exit_json(
changed=changed, server_id=server.id, metadata=server.metadata) changed=changed, server_id=server.id, metadata=server.metadata)
except sdk.exceptions.OpenStackCloudException as e:
module.fail_json(msg=e.message, extra_data=e.extra_data) def main():
module = ServerMetadataModule()
module()
if __name__ == '__main__': if __name__ == '__main__':