diff --git a/changelogs/fragments/64495-os_network-openstacksdk-min.yml b/changelogs/fragments/64495-os_network-openstacksdk-min.yml new file mode 100644 index 00000000..7fd35acb --- /dev/null +++ b/changelogs/fragments/64495-os_network-openstacksdk-min.yml @@ -0,0 +1,3 @@ +bugfixes: + - bump the minimum openstacksdk version when os_network + uses the dns_domain argument diff --git a/plugins/modules/os_network.py b/plugins/modules/os_network.py index e31357f6..163ecd11 100644 --- a/plugins/modules/os_network.py +++ b/plugins/modules/os_network.py @@ -77,7 +77,7 @@ options: type: int dns_domain: description: - - The DNS domain value to set. + - The DNS domain value to set. Requires openstacksdk>=0.29. Network will use Openstack defaults if this option is not provided. requirements: @@ -193,12 +193,18 @@ def main(): provider_physical_network = module.params['provider_physical_network'] provider_network_type = module.params['provider_network_type'] provider_segmentation_id = module.params['provider_segmentation_id'] - project = module.params.get('project') - port_security_enabled = module.params.get('port_security_enabled') - mtu = module.params.get('mtu') - dns_domain = module.params.get('dns_domain') + project = module.params['project'] - sdk, cloud = openstack_cloud_from_module(module) + net_create_kwargs = { + 'port_security_enabled': module.params['port_security_enabled'], + 'mtu_size': module.params['mtu'] + } + + if module.params['dns_domain'] is not None: + sdk, cloud = openstack_cloud_from_module(module, min_version='0.29.0') + net_create_kwargs['dns_domain'] = module.params['dns_domain'] + else: + sdk, cloud = openstack_cloud_from_module(module) try: if project is not None: proj = cloud.get_project(project) @@ -224,13 +230,11 @@ def main(): if project_id is not None: net = cloud.create_network(name, shared, admin_state_up, external, provider, project_id, - port_security_enabled=port_security_enabled, - mtu_size=mtu, dns_domain=dns_domain) + **net_create_kwargs) else: net = cloud.create_network(name, shared, admin_state_up, external, provider, - port_security_enabled=port_security_enabled, - mtu_size=mtu, dns_domain=dns_domain) + **net_create_kwargs) changed = True else: changed = False