internet/ansible-collections-openstack
3
0
Fork 0
mirror of https://opendev.org/openstack/ansible-collections-openstack.git synced 2026-05-14 05:22:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge "Only clear out security groups if the parameter is set"

Browse Source
This commit is contained in:
Zuul
2026-05-11 21:11:14 +00:00
committed by Gerrit Code Review
parent 0e6e281316 b1e4d4b714
commit 143c959f7d
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/modules/server.py
View File

@@ -195,10 +195,12 @@ options:
added. added.
- On server creation, if I(security_groups) is omitted, the API creates - On server creation, if I(security_groups) is omitted, the API creates
the server in the default security group. the server in the default security group.
- Requested security groups are not applied to pre-existing ports. - On server creation, requested security groups are not applied to
pre-existing ports.
- On update, if I(security_groups) is set, the security groups are
applied to all attached ports.
type: list type: list
elements: str elements: str
default: []
state: state:
description: description:
- Should the resource be C(present) or C(absent). - Should the resource be C(present) or C(absent).
@@ -830,7 +832,7 @@ class ServerModule(OpenStackModule):
nics=dict(default=[], type='list', elements='raw'), nics=dict(default=[], type='list', elements='raw'),
reuse_ips=dict(default=True, type='bool'), reuse_ips=dict(default=True, type='bool'),
scheduler_hints=dict(type='dict'), scheduler_hints=dict(type='dict'),
security_groups=dict(default=[], type='list', elements='str'), security_groups=dict(type='list', elements='str'),
state=dict(default='present', choices=['absent', 'present']), state=dict(default='present', choices=['absent', 'present']),
tags=dict(type='list', default=[], elements='str'), tags=dict(type='list', default=[], elements='str'),
terminate_volume=dict(default=False, type='bool'), terminate_volume=dict(default=False, type='bool'),
@@ -952,6 +954,9 @@ class ServerModule(OpenStackModule):
def _build_update_security_groups(self, server): def _build_update_security_groups(self, server):
update = {} update = {}
if self.params['security_groups'] is None:
return update
required_security_groups = dict( required_security_groups = dict(
(sg['id'], sg) for sg in [ (sg['id'], sg) for sg in [
self.conn.network.find_security_group( self.conn.network.find_security_group(