internet/ansible-collections-openstack
3
0
Fork 0
mirror of https://opendev.org/openstack/ansible-collections-openstack.git synced 2026-05-06 05:13:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Dropped default module options

Browse Source 
Removed default=None, type='str' and required=False from all module's
argument_specs with

sed -i \
    -e 's/default=None, //g' \
    -e 's/default=None,//g' \
    -e 's/default=None//g' \
    -e "s/type='str', //g" \
    -e "s/type='str',//g" \
    -e "s/type='str'//g" \
    -e 's/required=False, //g' \
    -e 's/required=False,//g' \
    -e 's/required=False//g' \
    plugins/modules/*.py plugins/module_utils/*.py

and manually cleaned the results because those options values are the
default in Ansible.

Ref.: https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#argument-spec

Change-Id: Icbc3bb84269d3b8205fac259300902ebdaf6a3ae
This commit is contained in:
Jakob Meng
2022-07-27 12:39:44 +02:00
parent ceae5c1030
commit 0215e2a5d4
72 changed files with 397 additions and 408 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/module_utils/ironic.py
View File

@@ -30,8 +30,8 @@ from ansible_collections.openstack.cloud.plugins.module_utils.openstack import o
def ironic_argument_spec(**kwargs):
spec = dict(
auth_type=dict(required=False),
ironic_url=dict(required=False),
auth_type=dict(),
ironic_url=dict(),
)
spec.update(kwargs)
return openstack_full_argument_spec(**spec)

24
plugins/module_utils/openstack.py
View File

@@ -89,24 +89,24 @@ def openstack_find_nova_addresses(addresses, ext_tag, key_name=None):
def openstack_full_argument_spec(**kwargs):
spec = dict(
cloud=dict(default=None, type='raw'),
auth_type=dict(default=None),
auth=dict(default=None, type='dict', no_log=True),
region_name=dict(default=None),
availability_zone=dict(default=None),
validate_certs=dict(default=None, type='bool', aliases=['verify']),
ca_cert=dict(default=None, aliases=['cacert']),
client_cert=dict(default=None, aliases=['cert']),
client_key=dict(default=None, no_log=True, aliases=['key']),
cloud=dict(type='raw'),
auth_type=dict(),
auth=dict(type='dict', no_log=True),
region_name=dict(),
availability_zone=dict(),
validate_certs=dict(type='bool', aliases=['verify']),
ca_cert=dict(aliases=['cacert']),
client_cert=dict(aliases=['cert']),
client_key=dict(no_log=True, aliases=['key']),
wait=dict(default=True, type='bool'),
timeout=dict(default=180, type='int'),
api_timeout=dict(default=None, type='int'),
api_timeout=dict(type='int'),
interface=dict(
default='public', choices=['public', 'internal', 'admin'],
aliases=['endpoint_type']),
sdk_log_path=dict(default=None, type='str'),
sdk_log_path=dict(),
sdk_log_level=dict(
default='INFO', type='str', choices=['INFO', 'DEBUG']),
default='INFO', choices=['INFO', 'DEBUG']),
)
# Filter out all our custom parameters before passing to AnsibleModule
kwargs_copy = copy.deepcopy(kwargs)