* synchronize: fix changed status with link_dest
With link_dest the module runs rsync with -vv, which also itemizes
unchanged files as '.f' followed by spaces. Any such line made the
module report no change, even when other files in the same run were
transferred, deleted or had their permissions updated.
Treat a line as unchanged only when it starts with a period and has no
attribute changes, which is how rsync lists files it did not touch.
Signed-off-by: Luca Marsella <marsluca7@gmail.com>
Assisted-by: Claude Opus 5.5
* synchronize: don't make link_dest test files world-readable
SonarCloud flags the new test tasks for granting access to others.
The test does not need it, so use 0750 and 0640 instead.
Signed-off-by: Luca Marsella <marsluca7@gmail.com>
* synchronize: read rsync markers only at the start of a line
The link_dest check split the whole output on the marker, so a file
name that contains the marker made a no-op sync report a change.
Signed-off-by: Luca Marsella <marsluca7@gmail.com>
---------
Signed-off-by: Luca Marsella <marsluca7@gmail.com>
Example :
cd "/home/a/ansible plays"
task:
- synchronize:
src: a
dest: b
Results in the following error being thrown
fatal: [remote-host]: FAILED! => {"changed": false, "cmd": "/usr/bin/rsync --delay-updates -F --compress --archive --rsh='/usr/bin/ssh -S none -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null' --rsync-path='sudo -u root rsync' --out-format='<<CHANGED>>%i %n%L' /home/a/ansible plays/deployments// remote-user@remote-host:/data/", "msg": "rsync: [sender] link_stat \"/home/a/ansible\" failed: No such file or directory (2)\nrsync: [sender] change_dir \"/home/a/ansible plays/plays/a/\" failed: No such file or directory (2)\nrsync error: some files/attrs were not transferred (see previous errors) (code 23) at main.c(1330) [sender=3.2.3]\n", "rc": 23}
The synchronize action plugin and module were a bit sloppy when it
came to the command-line parameter quoting and that caused failuer on
some systems (for example, on Fedora 34).
This commit makes sure any argumnts with potentially problematic
characters are quoted before being used.