275 Commits
Author SHA1 Message Date
Luca MarsellaandGitHub 4daa61d294 synchronize: fix changed status with link_dest (#812)
* synchronize: fix changed status with link_dest

With link_dest the module runs rsync with -vv, which also itemizes
unchanged files as '.f' followed by spaces. Any such line made the
module report no change, even when other files in the same run were
transferred, deleted or had their permissions updated.

Treat a line as unchanged only when it starts with a period and has no
attribute changes, which is how rsync lists files it did not touch.

Signed-off-by: Luca Marsella <marsluca7@gmail.com>
Assisted-by: Claude Opus 5.5

* synchronize: don't make link_dest test files world-readable

SonarCloud flags the new test tasks for granting access to others.
The test does not need it, so use 0750 and 0640 instead.

Signed-off-by: Luca Marsella <marsluca7@gmail.com>

* synchronize: read rsync markers only at the start of a line

The link_dest check split the whole output on the marker, so a file
name that contains the marker made a no-op sync report a change.

Signed-off-by: Luca Marsella <marsluca7@gmail.com>

---------

Signed-off-by: Luca Marsella <marsluca7@gmail.com>
2026-11-16 16:16:54 +09:00
Hideki SaitoandGitHub 4bd26a3cc6 Updated AZP test: (#817)
* Added ansible core 2.22 tests
* Updated remote OS targets
* Remove ansible core 2.17 from AZP remote test
* Fixed the substitution logic for AZP test job parameters

Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-11-10 15:14:07 +09:00
Hideki SaitoandGitHub 0f4453f85e Update AZP remote tests (#809)
* Removing FreeBSD 13.5.
* Pinning RHEL 9.8 to Python 3.9 to keep compatibility with Python firewall library.

Signed-off-by: Hideki Saito <saito@fgrep.org>

test
2026-10-21 08:25:54 +09:00
dddd6c9b35 firewalld_info: fail cleanly when D-Bus is unavailable (#805)
python-firewall wraps a missing D-Bus socket in FirewallError, which the module did not catch, so Ansible reported a module crash instead of a normal failure.

Fixes #678


Assisted-by: Grok 4.7

Signed-off-by: Nikhil Jain <nikhjain@redhat.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
2026-10-19 17:05:46 +09:00
Hideki SaitoandGitHub d5699a3fcf Replace FreeBSD version 14.4 with 14.5 for remote test (#796)
Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-09-15 15:13:35 +09:00
Susmita SenandGitHub 2f2a8e9b96 ACA-4558: synchronize: use ansible_host from play vars when absent from hostvars (#779)
* synchronize: use ansible_host from play vars when absent from hostvars

The synchronize action plugin built the rsync/ssh destination
exclusively from task_vars['hostvars'][inventory_hostname]. When
ansible_host was set via play-level vars: rather than inventory/
group_vars/host_vars, it was absent from that snapshot and the plugin
silently fell back to bare inventory_hostname, producing 'Host not
found' errors when ansible_host differed from the inventory name.

Fixes #469
2026-09-14 17:38:58 +09:00
Hideki SaitoandGitHub 93f25f88b8 Fix integration test for mount module for Ansible Core 2.22 or later (#794)
- Fixes #793

Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-09-14 17:16:26 +09:00
Michael SprottandGitHub 20699d7184 mount: Create a state like absent but keeps the mountpoint (#774)
* Create a new state, with an example and integration test

* Now that I have my PR, add in my changelog

* Fix linter issues

* Another attempt at getting the sanity tests to pass

* Fix FreeBSD integration test

* Try to get sonarcloud code analysis happy

* Change state option name
2026-08-31 12:51:24 +09:00
Abhijeet KasurdeandGitHub 035d4ad0a3 mount: restore fstab file if umount fails (#742)
* mount: restore fstab file if umount fails

* Refactored code

Fixes: #605

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

* Make CI green

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>

---------

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2026-08-26 10:39:24 +09:00
Hideki SaitoandGitHub 90c3bd65bf Fix version_added for profile_tasks datetime_format (#784)
- Fixes #783
- Replaced version_added value with 2.2.0 for datetime_format

Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-08-25 17:55:49 +09:00
Hideki SaitoandGitHub 713a132aaa [CI] Bump partner-certification-checker to v4.1.0 (#780)
- Fixes ansible-lint import crash

Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-08-25 15:16:05 +09:00
Tom PaineandGitHub 5dd6507835 fix(callback): align profile_tasks recap output width (#773)
Use display.columns and get_text_width() for TASKS RECAP headers,
timestamps, and timing rows so output matches display.banner() width.
Add truncate_task_names (default false, version_added 2.3.0) with
display-width-aware truncation and padding for multibyte task names.
Add unit tests for ASCII and CJK recap rows, including the reproducer
from #773.
2026-08-25 09:19:51 +09:00
Hideki SaitoandGitHub ffdf9ef998 Update AZP to follow ansible-test (#775)
- Replace FreeBSD 15.0 with 15.1

Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-08-07 14:16:48 +09:00
Hideki SaitoandGitHub ef1937b771 Update README Support section to reference Red Hat Automation Hub (#768)
Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-07-08 08:37:41 +09:00
Hideki SaitoandGitHub bf4e5d917e Remove meta-runtime[unsupported-version] line from the skip_list (#767)
Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-07-08 08:14:25 +09:00
Hideki SaitoandGitHub e114652e45 Replace remote test env RHEL9.7 and 10.1 with 9.8 and 10.2 (#763)
- Replace 9.7 with 9.8
- Replace 10.1 with 10.2
- Addresses https://github.com/ansible/ansible/pull/87120

Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-07-01 10:39:34 +09:00
Hideki SaitoandGitHub 18f2f69c53 Fixes the symlink handling issue in the authorized_key module (#760)
- Addresses CVE-2026-11837
- Fixes #759

Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-06-30 08:45:30 +09:00
Hideki SaitoandGitHub 674315f2da Replace AZP remote test FreeBSD-14.2 with 14.3 for Ansible Core 2.19 (#755)
Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-06-09 21:21:39 +09:00
Hideki SaitoandGitHub f7945c4bc9 [CI] AZP bump test container version to 8.0.0 (#751)
- Bump test container version to 8.0.0 for Ansible Core 2.18+
- Keep using 7.0.0 for Ansible Core 2.16 and 2.17. Both versions don't support Python3.13.

Signed-off-by: Hideki Saito <saito@fgrep.org>
2026-06-01 03:34:12 -07:00
Vladimir BotkaandGitHub 3c232a2429 In FreeBSD, fail if loader.conf shall be reloaded. (#664)
Fix #663
2026-05-20 08:43:23 -07:00
9cd0a1f0ef docs: added attributes metadata for check_mode support (fixes #643) (#741)
Co-authored-by: jkhall81 <jason.kei.hall@gmail.com>
2026-05-21 00:24:37 +09:00
Felix FonteinandGitHub 3059c5138c Fix changelog fragment. (#720)
The changelog fragment for #687 claims that a feature is removed, which isn't the case. It's a simple bugfix.
2026-05-17 23:40:16 +09:00
Abhijeet KasurdeandGitHub dbeb4a861d firewalld_info: Use PY2 compatible syntax (#719)
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2026-05-15 12:07:12 -07:00
Abhijeet KasurdeandGitHub 7cbef04377 Removed ANSIBLE_METADATA from remaining plugins (#717)
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2026-05-14 07:28:14 +09:00
ca22c6fe26 Fix _AnsibleActionDone deprecation in patch plugin (#687)
Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
Co-authored-by: Lee Garrett <lgarrett@rocketjump.eu>
2026-05-13 04:20:49 -07:00
Abhijeet KasurdeandGitHub d88a3c833c firewalld_info: Use module.warn (#715)
* Use module.warn to display warnings instead of module.exit_json

Fixes: #710

Signed-off-by: Abhijeet Kasurde <Akasurde@redhat.com>
2026-05-11 17:47:10 -07:00
SilejonuandAbhijeet Kasurde 871b4daeeb fix(acl): correctly assert needed changes when recursive is true 2026-05-07 09:55:28 -04:00
Pavel BarandCursor AI 42d76de1cf Add changelog fragment for deprecated imports fix
Co-authored-by: Cursor AI
Signed-off-by: Pavel Bar <pbar@redhat.com>
2026-05-06 19:06:51 +03:00
Hideki Saito 7d5aef07e2 Update AZP CI matrix and sanity test
* Update AZP CI matrix
* Add ignore file for Ansible Core 2.21
* Remove ignore lines for ansible-bad-import-from in 2.20 sanity tests

Signed-off-by: Hideki Saito <saito@fgrep.org>
2025-12-09 05:23:05 +00:00
Klaas Demter 413ab782a8 Fixes #462 notice permission denied on authorized_key module 2025-10-21 10:00:12 +02:00
softwarefactory-project-zuul[bot]andGitHub 9343c6f56f Merge pull request #682 from saito-hideki/pr/ci_update_20250929
Ignore pylint errors caused by compatibility checks for six

SUMMARY
Ignore pylint errors caused by compatibility checks for six:

pylint:ansible-bad-import-from

Ansible Core 2.16 supports Python2 environment,  and six is required to maintain compatibility with Python 2.
We plan to continue supporting Ansible Core 2.16 at this time.
Additionally, removing the standalone ansible-lint test because it is already included in ansible-test sanity.
ISSUE TYPE

CI tests Request

COMPONENT NAME

ansible.posix

ADDITIONAL INFORMATION
None

Reviewed-by: Andrew Klychkov <aklychko@redhat.com>
Reviewed-by: Felix Fontein <felix@fontein.de>
Reviewed-by: Hideki Saito <saito@fgrep.org>
2025-10-02 05:55:28 +00:00
saito-hideki 9dc73a686a Ignore pylint errors caused by compatibility checks for six
* This is a temporary measure until we stop covering Python2
* Skipped sanity[cannot-ignore] to keep backward compatibility with Python2
* Consolidate all ansible-lint option locations into .ansible-lint
* Fixed some typos

Signed-off-by: saito-hideki <saito@fgrep.org>
2025-10-02 14:02:56 +09:00
Felix Fontein ab8dfefd90 Use module.warn() instead of returning warnings. 2025-08-06 06:49:32 +02:00
saito-hideki 2d350e6073 AZP update CI matrix
* Addresses #672
* Bump test container version 7.0.0
* Removes Ansible Core 2.15 tests. Python 3.11 is no longer supported in Container 7.0.0.

Signed-off-by: saito-hideki <saito@fgrep.org>
2025-08-05 14:30:30 +09:00
saito-hideki 9007e20b2f README updated with the release of Ansible Core 2.19
* https://docs.ansible.com/ansible/devel/roadmap/ROADMAP_2_19.html

Signed-off-by: saito-hideki <saito@fgrep.org>
2025-07-28 17:12:02 +09:00
saito-hideki 18e023dd77 Update AZP matrix to follow ansible-test changes
* https://github.com/ansible/ansible/pull/85558
* https://github.com/ansible/ansible/pull/85561
* https://github.com/ansible/ansible/pull/85562

Signed-off-by: saito-hideki <saito@fgrep.org>
2025-07-28 14:59:14 +09:00
Hideki SAITO 162e72182f Fixed syntax error in azurepileline settings
Signed-off-by: Hideki SAITO <hsaito@macallan.home.fgrep.org>
2025-07-17 12:16:09 +09:00
saito-hideki 40c27e2bee CI - bump ansible-core version
* bump devel to ansible-core 2.20
* add ansible-core 2.19 to stable list

Signed-off-by: saito-hideki <saito@fgrep.org>
2025-07-10 09:35:28 +09:00
Felix Fontein f978998521 Add changelog fragment. 2025-06-28 16:34:47 +02:00
saito-hideki f977bffff2 [AZP] Add RHEL10 environment to CI matrix
* Fixes #642

Signed-off-by: saito-hideki <saito@fgrep.org>
2025-06-09 18:43:43 +09:00
Pablo Méndez Hernández 2f224e6a6a Add option to provide a different date/time format
The new `datetime_format` key will offer the possibility of
providing a different date/time format than the default one
(`'%A %d %B %Y  %H:%M:%S %z'`).

- The `iso8601` value can be used as an `'%Y-%m-%dT%H:%M:%S.%f'`
  alias (format of the ISO 8601 date/time standard).

The code has changed from using the `time` API to the `datetime`
one in order to support sub-second precision (needed by the ISO
8601 format, for example).

Signed-off-by: Pablo Mendez Hernandez <pablomh@redhat.com>
2025-04-17 15:57:00 +02:00
Hideki Saito 7b9b1f4957 Fixes issue related to updating the ansible-core devel branch
* Fixes incorrect load path for json module in cgroup_perf_recap
* Remove unnecessary condition from seboolean integration tests
* Optimize conditions for selinux integration tests
* Fixes #630

Signed-off-by: Hideki Saito <saito@fgrep.org>
2025-04-17 00:11:31 +00:00
Hideki Saito 2cec8cbed5 [CI] Remove ubuntu20.04 from CI tests
* Fixes #612

Signed-off-by: Hideki Saito <saito@fgrep.org>
2025-03-28 10:04:16 +09:00
Hideki Saito 83288b9020 Bump version to 3.0.0 for the next release
* Fixes #603

Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-12-10 17:30:22 +09:00
Hideki Saito f5eae12146 Release 2.0.0 commit
Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-12-04 09:46:44 +09:00
softwarefactory-project-zuul[bot]andGitHub f632fad9d4 Merge pull request #598 from saito-hideki/issue/586
[Breaking Change] [firewalld] Change type of icmp_block_inversion option from str to bool

SUMMARY
Changed the type of icmp_block_inversion option from str to bool

Fixes #586

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible.posix.firewalld

ADDITIONAL INFORMATION
Related  #582 and #584

Reviewed-by: Adam Miller <admiller@redhat.com>
Reviewed-by: Andrew Klychkov <aklychko@redhat.com>
2024-12-02 23:50:26 +00:00
Vladimir Botka 91129ed381 Fix changelog fragment module name. 2024-11-29 03:34:14 +01:00
Vladimir Botka 7b8d627552 Changelog fragment added. 2024-11-28 08:17:41 +01:00
Hideki Saito 6175a5028b Change type of icmp_block_inversion option from str to bool
* Fixes #586

Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-11-28 14:19:20 +09:00
Hideki Saito ae95adcfdc Replace FreeBSD 13.3 with 13.4 and add FreeBSD 14.1 for devel
It's for integration test environments for ansible-core devel.

Signed-off-by: Hideki Saito <saito@fgrep.org>
2024-11-14 14:23:53 +09:00