mirror of
https://github.com/ansible-collections/ansible.posix.git
synced 2026-05-08 06:13:02 +00:00
refactor to comply with current ansible-lint and sanity guidelines
Signed-off-by: Adam Miller <admiller@redhat.com>
This commit is contained in:
Adam Miller
@@ -1,2 +1,3 @@
|
||||
---
|
||||
dependencies:
|
||||
- prepare_tests
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
---
|
||||
# Test code for the sysctl module.
|
||||
# (c) 2017, James Tanner <tanner.jc@gmail.com>
|
||||
|
||||
@@ -24,79 +25,91 @@
|
||||
when:
|
||||
- ansible_facts.virtualization_type == 'docker' or ansible_facts.virtualization_type == 'container'
|
||||
block:
|
||||
- set_fact:
|
||||
- name: Set output_dir_test fact
|
||||
ansible.builtin.set_fact:
|
||||
output_dir_test: "{{ output_dir }}/test_sysctl"
|
||||
|
||||
- name: make sure our testing sub-directory does not exist
|
||||
file:
|
||||
- name: Make sure our testing sub-directory does not exist
|
||||
ansible.builtin.file:
|
||||
path: "{{ output_dir_test }}"
|
||||
state: absent
|
||||
|
||||
- name: create our testing sub-directory
|
||||
file:
|
||||
- name: Create our testing sub-directory
|
||||
ansible.builtin.file:
|
||||
path: "{{ output_dir_test }}"
|
||||
state: directory
|
||||
mode: "0755"
|
||||
|
||||
##
|
||||
## sysctl - file manipulation
|
||||
##
|
||||
|
||||
- name: copy the example conf to the test dir
|
||||
copy:
|
||||
- name: Copy the example conf to the test dir
|
||||
ansible.builtin.copy:
|
||||
src: sysctl.conf
|
||||
dest: "{{ output_dir_test }}"
|
||||
mode: "0644"
|
||||
|
||||
- name: Set vm.swappiness to 5
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: vm.swappiness
|
||||
value: 5
|
||||
state: present
|
||||
reload: no
|
||||
reload: false
|
||||
sysctl_file: "{{ output_dir_test }}/sysctl.conf"
|
||||
register: sysctl_test0
|
||||
|
||||
- debug:
|
||||
- name: Debug sysctl_test0
|
||||
ansible.builtin.debug:
|
||||
var: sysctl_test0
|
||||
verbosity: 1
|
||||
|
||||
- name: get file content
|
||||
shell: "cat {{ output_dir_test }}/sysctl.conf | egrep -v ^\\#"
|
||||
- name: Get file content
|
||||
ansible.builtin.shell:
|
||||
cmd: set -o pipefail && cat {{ output_dir_test }}/sysctl.conf | egrep -v ^\#
|
||||
executable: /bin/bash
|
||||
changed_when: false
|
||||
register: sysctl_content0
|
||||
|
||||
- debug:
|
||||
- name: Debug sysctl_content0
|
||||
ansible.builtin.debug:
|
||||
var: sysctl_content0
|
||||
verbosity: 1
|
||||
|
||||
- name: Set vm.swappiness to 5 again
|
||||
sysctl:
|
||||
name: vm.swappiness
|
||||
value: 5
|
||||
state: present
|
||||
reload: no
|
||||
sysctl_file: "{{ output_dir_test }}/sysctl.conf"
|
||||
ansible.posix.sysctl:
|
||||
name: vm.swappiness
|
||||
value: 5
|
||||
state: present
|
||||
reload: false
|
||||
sysctl_file: "{{ output_dir_test }}/sysctl.conf"
|
||||
register: sysctl_test1
|
||||
|
||||
- name: validate results
|
||||
assert:
|
||||
that:
|
||||
- sysctl_test0 is changed
|
||||
- sysctl_test1 is not changed
|
||||
- 'sysctl_content0.stdout_lines[sysctl_content0.stdout_lines.index("vm.swappiness=5")] == "vm.swappiness=5"'
|
||||
- name: Validate results
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_test0 is changed
|
||||
- sysctl_test1 is not changed
|
||||
- sysctl_content0.stdout_lines[sysctl_content0.stdout_lines.index("vm.swappiness=5")] == "vm.swappiness=5"
|
||||
|
||||
- name: Remove kernel.panic
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: kernel.panic
|
||||
value: 2
|
||||
reload: no
|
||||
reload: false
|
||||
state: absent
|
||||
sysctl_file: "{{ output_dir_test }}/sysctl.conf"
|
||||
register: sysctl_test2
|
||||
|
||||
- name: get file content
|
||||
shell: "cat {{ output_dir_test }}/sysctl.conf | egrep -v ^\\#"
|
||||
- name: Get file content
|
||||
ansible.builtin.shell:
|
||||
cmd: set -o pipefail && cat {{ output_dir_test }}/sysctl.conf | egrep -v ^\#
|
||||
executable: /bin/bash
|
||||
changed_when: false
|
||||
register: sysctl_content2
|
||||
|
||||
- debug:
|
||||
- name: Debug sysctl_test2 sysctl_content2
|
||||
ansible.builtin.debug:
|
||||
var: item
|
||||
verbosity: 1
|
||||
with_items:
|
||||
@@ -104,38 +117,39 @@
|
||||
- "{{ sysctl_content2 }}"
|
||||
|
||||
- name: Validate results for key removal
|
||||
assert:
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_test2 is changed
|
||||
- "'kernel.panic' not in sysctl_content2.stdout_lines"
|
||||
|
||||
- name: Test remove kernel.panic again
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: kernel.panic
|
||||
value: 2
|
||||
state: absent
|
||||
reload: no
|
||||
reload: false
|
||||
sysctl_file: "{{ output_dir_test }}/sysctl.conf"
|
||||
register: sysctl_test2_change_test
|
||||
|
||||
- name: Assert that no change was made
|
||||
assert:
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_test2_change_test is not changed
|
||||
|
||||
- name: Try sysctl with an invalid name
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: test.invalid
|
||||
value: 1
|
||||
register: sysctl_test3
|
||||
ignore_errors: yes
|
||||
ignore_errors: true
|
||||
|
||||
- debug:
|
||||
- name: Debug sysctl_test3
|
||||
ansible.builtin.debug:
|
||||
var: sysctl_test3
|
||||
verbosity: 1
|
||||
|
||||
- name: validate results for test 3
|
||||
assert:
|
||||
- name: Validate results for test 3
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_test3 is failed
|
||||
|
||||
@@ -143,77 +157,79 @@
|
||||
## sysctl - sysctl_set
|
||||
##
|
||||
|
||||
- name: set net.ipv4.ip_forward
|
||||
sysctl:
|
||||
- name: Set net.ipv4.ip_forward
|
||||
ansible.posix.sysctl:
|
||||
name: net.ipv4.ip_forward
|
||||
value: 1
|
||||
sysctl_set: yes
|
||||
reload: no
|
||||
sysctl_set: true
|
||||
reload: false
|
||||
register: sysctl_test3
|
||||
|
||||
- name: check with sysctl command
|
||||
shell: sysctl net.ipv4.ip_forward
|
||||
- name: Check with sysctl command
|
||||
ansible.builtin.command: sysctl net.ipv4.ip_forward
|
||||
changed_when: false
|
||||
register: sysctl_check3
|
||||
|
||||
- debug:
|
||||
- name: Debug sysctl_test3 sysctl_check3
|
||||
ansible.builtin.debug:
|
||||
var: item
|
||||
verbosity: 1
|
||||
with_items:
|
||||
- "{{ sysctl_test3 }}"
|
||||
- "{{ sysctl_check3 }}"
|
||||
|
||||
- name: validate results for test 3
|
||||
assert:
|
||||
- name: Validate results for test 3
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_test3 is changed
|
||||
- 'sysctl_check3.stdout_lines == ["net.ipv4.ip_forward = 1"]'
|
||||
- sysctl_check3.stdout_lines == ["net.ipv4.ip_forward = 1"]
|
||||
|
||||
- name: Try sysctl with no name
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: ""
|
||||
value: 1
|
||||
sysctl_set: yes
|
||||
ignore_errors: True
|
||||
sysctl_set: true
|
||||
ignore_errors: true
|
||||
register: sysctl_no_name
|
||||
|
||||
- name: validate nameless results
|
||||
assert:
|
||||
- name: Validate nameless results
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_no_name is failed
|
||||
- "sysctl_no_name.msg == 'name cannot be blank'"
|
||||
- sysctl_no_name.msg == 'name cannot be blank'
|
||||
|
||||
- name: Try sysctl with no value
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: Foo
|
||||
value:
|
||||
sysctl_set: yes
|
||||
ignore_errors: True
|
||||
sysctl_set: true
|
||||
ignore_errors: true
|
||||
register: sysctl_no_value
|
||||
|
||||
- name: validate nameless results
|
||||
assert:
|
||||
- name: Validate nameless results
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_no_value is failed
|
||||
- "sysctl_no_value.msg == 'value cannot be None'"
|
||||
- sysctl_no_value.msg == 'value cannot be None'
|
||||
|
||||
- name: Try sysctl with an invalid name
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: test.invalid
|
||||
value: 1
|
||||
sysctl_set: yes
|
||||
sysctl_set: true
|
||||
register: sysctl_test4
|
||||
ignore_errors: yes
|
||||
ignore_errors: true
|
||||
|
||||
- debug:
|
||||
- name: Debug sysctl_test4
|
||||
ansible.builtin.debug:
|
||||
var: sysctl_test4
|
||||
verbosity: 1
|
||||
|
||||
- name: validate results for test 4
|
||||
assert:
|
||||
- name: Validate results for test 4
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_test4 is failed
|
||||
|
||||
|
||||
- name: Test on RHEL VMs
|
||||
when:
|
||||
- ansible_facts.virtualization_type != 'docker'
|
||||
@@ -221,34 +237,37 @@
|
||||
block:
|
||||
# Test reload: yes
|
||||
- name: Set sysctl property using module
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: vm.swappiness
|
||||
value: '22'
|
||||
value: "22"
|
||||
state: present
|
||||
reload: yes
|
||||
reload: true
|
||||
register: sysctl_set1
|
||||
|
||||
- name: Change sysctl property using command
|
||||
command: sysctl vm.swappiness=33
|
||||
ansible.builtin.command: sysctl vm.swappiness=33
|
||||
changed_when: true
|
||||
|
||||
- name: Set sysctl property using module
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: vm.swappiness
|
||||
value: '22'
|
||||
value: "22"
|
||||
state: present
|
||||
reload: yes
|
||||
reload: true
|
||||
register: sysctl_set2
|
||||
|
||||
- name: Read /etc/sysctl.conf
|
||||
command: 'egrep -v ^# /etc/sysctl.conf'
|
||||
ansible.builtin.command: egrep -v ^# /etc/sysctl.conf
|
||||
changed_when: false
|
||||
register: sysctl_conf_content
|
||||
|
||||
- name: Get current value of vm.swappiness
|
||||
command: sysctl -n vm.swappiness
|
||||
ansible.builtin.command: sysctl -n vm.swappiness
|
||||
changed_when: false
|
||||
register: sysctl_current_vm_swappiness
|
||||
|
||||
- name: Ensure changes were made appropriately
|
||||
assert:
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_set1 is changed
|
||||
- sysctl_set2 is changed
|
||||
@@ -257,33 +276,35 @@
|
||||
|
||||
# Test reload: yes in check mode
|
||||
- name: Set the same value using module in check mode
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: vm.swappiness
|
||||
value: '22'
|
||||
value: "22"
|
||||
state: present
|
||||
reload: yes
|
||||
check_mode: yes
|
||||
reload: true
|
||||
check_mode: true
|
||||
register: sysctl_check_mode1
|
||||
|
||||
- name: Set a different value using module in check mode
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: vm.swappiness
|
||||
value: '44'
|
||||
value: "44"
|
||||
state: present
|
||||
reload: yes
|
||||
check_mode: yes
|
||||
reload: true
|
||||
check_mode: true
|
||||
register: sysctl_check_mode2
|
||||
|
||||
- name: Read /etc/sysctl.conf
|
||||
command: 'egrep -v ^# /etc/sysctl.conf'
|
||||
ansible.builtin.command: egrep -v ^# /etc/sysctl.conf
|
||||
changed_when: false
|
||||
register: sysctl_check_mode_conf_content
|
||||
|
||||
- name: Get current value of vm.swappiness
|
||||
command: sysctl -n vm.swappiness
|
||||
ansible.builtin.command: sysctl -n vm.swappiness
|
||||
changed_when: false
|
||||
register: sysctl_check_mode_current_vm_swappiness
|
||||
|
||||
- name: Ensure no changes were made in check mode
|
||||
assert:
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_check_mode1 is success
|
||||
- sysctl_check_mode2 is changed
|
||||
@@ -292,21 +313,22 @@
|
||||
|
||||
# Test sysctl: invalid value
|
||||
- name: Set invalid sysctl property using module
|
||||
sysctl:
|
||||
ansible.posix.sysctl:
|
||||
name: vm.mmap_rnd_bits
|
||||
value: '1024'
|
||||
value: "1024"
|
||||
state: present
|
||||
reload: yes
|
||||
sysctl_set: True
|
||||
ignore_errors: True
|
||||
reload: true
|
||||
sysctl_set: true
|
||||
ignore_errors: true
|
||||
register: sysctl_invalid_set1
|
||||
|
||||
- name: Read /etc/sysctl.conf
|
||||
command: 'cat /etc/sysctl.conf'
|
||||
ansible.builtin.command: cat /etc/sysctl.conf
|
||||
changed_when: false
|
||||
register: sysctl_invalid_conf_content
|
||||
|
||||
- name: Ensure changes were not made
|
||||
assert:
|
||||
ansible.builtin.assert:
|
||||
that:
|
||||
- sysctl_invalid_set1 is failed
|
||||
- "'vm.mmap_rnd_bits' not in sysctl_invalid_conf_content.stdout"
|
||||
|
||||
Reference in New Issue
Block a user