refactor to comply with current ansible-lint and sanity guidelines

Signed-off-by: Adam Miller <admiller@redhat.com>

tests/integration/targets/selinux/tasks/selogin.yml

@@ -1,70 +1,71 @@
-- name: create user for testing
-  user:
+---
+- name: Create user for testing
+  ansible.builtin.user:
     name: seuser
-- name: attempt to add mapping without 'seuser'
+- name: Attempt to add mapping without 'seuser'
   register: selogin_error
   ignore_errors: true
   community.general.system.selogin:
     login: seuser
-- name: verify failure
-  assert:
+- name: Verify failure
+  ansible.builtin.assert:
     that:
-    - selogin_error is failed
-- name: map login to SELinux user
+      - selogin_error is failed
+- name: Map login to SELinux user
   register: selogin_new_mapping
-  check_mode: '{{ item }}'
+  check_mode: "{{ item }}"
   with_items:
-  - true
-  - false
-  - true
-  - false
+    - true
+    - false
+    - true
+    - false
   community.general.system.selogin:
     login: seuser
     seuser: staff_u
-- name: new mapping- verify functionality and check_mode
-  assert:
+- name: New mapping- verify functionality and check_mode
+  ansible.builtin.assert:
     that:
-    - selogin_new_mapping.results[0] is changed
-    - selogin_new_mapping.results[1] is changed
-    - selogin_new_mapping.results[2] is not changed
-    - selogin_new_mapping.results[3] is not changed
-- name: change SELinux user login mapping
+      - selogin_new_mapping.results[0] is changed
+      - selogin_new_mapping.results[1] is changed
+      - selogin_new_mapping.results[2] is not changed
+      - selogin_new_mapping.results[3] is not changed
+- name: Change SELinux user login mapping
   register: selogin_mod_mapping
-  check_mode: '{{ item }}'
+  check_mode: "{{ item }}"
   with_items:
-  - true
-  - false
-  - true
-  - false
+    - true
+    - false
+    - true
+    - false
   community.general.system.selogin:
     login: seuser
     seuser: user_u
-- name: changed mapping- verify functionality and check_mode
-  assert:
+- name: Changed mapping- verify functionality and check_mode
+  ansible.builtin.assert:
     that:
-    - selogin_mod_mapping.results[0] is changed
-    - selogin_mod_mapping.results[1] is changed
-    - selogin_mod_mapping.results[2] is not changed
-    - selogin_mod_mapping.results[3] is not changed
-- name: remove SELinux user mapping
+      - selogin_mod_mapping.results[0] is changed
+      - selogin_mod_mapping.results[1] is changed
+      - selogin_mod_mapping.results[2] is not changed
+      - selogin_mod_mapping.results[3] is not changed
+- name: Remove SELinux user mapping
   register: selogin_del_mapping
-  check_mode: '{{ item }}'
+  check_mode: "{{ item }}"
   with_items:
-  - true
-  - false
-  - true
-  - false
+    - true
+    - false
+    - true
+    - false
   community.general.system.selogin:
     login: seuser
     state: absent
-- name: delete mapping- verify functionality and check_mode
-  assert:
+- name: Delete mapping- verify functionality and check_mode
+  ansible.builtin.assert:
     that:
-    - selogin_del_mapping.results[0] is changed
-    - selogin_del_mapping.results[1] is changed
-    - selogin_del_mapping.results[2] is not changed
-    - selogin_del_mapping.results[3] is not changed
-- name: remove test user
-  user:
+      - selogin_del_mapping.results[0] is changed
+      - selogin_del_mapping.results[1] is changed
+      - selogin_del_mapping.results[2] is not changed
+      - selogin_del_mapping.results[3] is not changed
+- name: Remove test user
+  ansible.builtin.user:
     name: seuser
     state: absent